Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c518e856b6d440d6f3e68b4621e8caeff3ae9b96
https://github.com/WebKit/WebKit/commit/c518e856b6d440d6f3e68b4621e8caeff3ae9b96
Author: Ruthvik Konda <[email protected]>
Date: 2026-03-11 (Wed, 11 Mar 2026)
Changed paths:
M
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm
Log Message:
-----------
[FairPlay] Remove incorrect ASSERT_NOT_REACHED in
externalProtectionStatusDidChangeForContentKey
https://bugs.webkit.org/show_bug.cgi?id=309629
rdar://171486386
Reviewed by Jean-Yves Avenard.
AVFoundation delivers externalProtectionStatusDidChangeForContentKey:
callbacks asynchronously via the shared AVContentKeySession delegate.
When the owning CDMInstanceSession is destroyed before the callback
arrives, sessionForKey() returns nullptr because the session's WeakPtr
in m_sessions is null and its m_requests have been cleared by
closeSession(). This is expected -- even if the callback could reach
the session, updateProtectionStatus() would no-op since m_requests
is empty and m_client is cleared.
Remove the ASSERT_NOT_REACHED which incorrectly treats this reachable
code path as unreachable. The ERROR_LOG remains for diagnostics.
*
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::externalProtectionStatusDidChangeForContentKey):
Canonical link: https://commits.webkit.org/309116@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
