Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d042d9b75315a2ad189d7baae74828ca68f9b5c7
https://github.com/WebKit/WebKit/commit/d042d9b75315a2ad189d7baae74828ca68f9b5c7
Author: Keith Miller <[email protected]>
Date: 2026-03-12 (Thu, 12 Mar 2026)
Changed paths:
M Source/JavaScriptCore/bytecode/CodeBlock.cpp
M Source/JavaScriptCore/bytecode/InlineAccess.cpp
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
M Source/JavaScriptCore/bytecode/PropertyInlineCache.cpp
M Source/JavaScriptCore/bytecode/PropertyInlineCache.h
M Source/JavaScriptCore/bytecode/Repatch.cpp
M Source/JavaScriptCore/dfg/DFGCommonData.h
M Source/JavaScriptCore/dfg/DFGJITCode.h
M Source/JavaScriptCore/dfg/DFGJITCompiler.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp
M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp
M Source/JavaScriptCore/ftl/FTLState.cpp
M Source/JavaScriptCore/jit/BaselineJITCode.h
M Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp
M Source/JavaScriptCore/jit/JITInlines.h
Log Message:
-----------
[JSC] Split PropertyInlineCache into subclasses
https://bugs.webkit.org/show_bug.cgi?id=309568
rdar://172190152
Reviewed by Yusuke Suzuki.
Split the monolithic PropertyInlineCache class into a base class with two
subclasses:
HandlerPropertyInlineCache (used by Baseline JIT and DFG) and
RepatchingPropertyInlineCache
(used by FTL and 32-bit DFG). The useHandlerIC boolean field is replaced by a
PropertyInlineCacheType enum and WTF type trait infrastructure, enabling
dynamicDowncast<>
and is<> checks throughout. Mode-specific fields — m_slowOperation and
m_inlinedHandler for
handler ICs; startLocation, m_slowPathCallLocation, m_stub, and
inlineCodeSize() for
repatching ICs — are moved to the appropriate subclass.
DFG::CommonData now holds two separate Bags (m_handlerPropertyInlineCaches and
m_repatchingPropertyInlineCaches) instead of a single m_propertyInlineCaches
bag, and
FTL::State::addPropertyInlineCache() selects which bag to use based on the
useHandlerICInFTL option.
I also added a FIXME to move the various regs (m_baseGPR, m_extraGPR, etc) to
RepatchingPropertyInlineCache and have HandlerPropertyInlineCache use fixed
values. This is slightly non-trivial because the different AccessTypes use
different registers for each of the values.
Canonical link: https://commits.webkit.org/309143@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
