Modified: trunk/Source/WebCore/ChangeLog (114390 => 114391)
--- trunk/Source/WebCore/ChangeLog 2012-04-17 17:09:40 UTC (rev 114390)
+++ trunk/Source/WebCore/ChangeLog 2012-04-17 17:12:19 UTC (rev 114391)
@@ -1,3 +1,17 @@
+2012-04-17 Vivek Galatage <vivekgalat...@gmail.com>
+
+ Script make_names.pl should generate consistent .h & .cpp files
+ https://bugs.webkit.org/show_bug.cgi?id=84140
+
+ Reviewed by Kentaro Hara.
+
+ Added a newline character and removed ';' after the DEFINE_GLOBAL
+
+ No test cases required for this change.
+
+ * dom/make_names.pl:
+ (printNamesCppFile):
+
2012-04-17 Aaron Colwell <acolw...@chromium.org>
Add webkitSourceAddId() & webkitSourceRemoveId() to HTMLMediaElement
Modified: trunk/Source/WebCore/dom/make_names.pl (114390 => 114391)
--- trunk/Source/WebCore/dom/make_names.pl 2012-04-17 17:09:40 UTC (rev 114390)
+++ trunk/Source/WebCore/dom/make_names.pl 2012-04-17 17:12:19 UTC (rev 114391)
@@ -622,12 +622,12 @@
my $lowerNamespace = lc($parameters{namespacePrefix});
- print F "DEFINE_GLOBAL(AtomicString, ${lowerNamespace}NamespaceURI, \"$parameters{namespaceURI}\")";
+ print F "DEFINE_GLOBAL(AtomicString, ${lowerNamespace}NamespaceURI, \"$parameters{namespaceURI}\")\n\n";
if (keys %allTags) {
print F "// Tags\n";
for my $name (sort keys %allTags) {
- print F "DEFINE_GLOBAL(QualifiedName, ", $name, "Tag, nullAtom, \"$name\", ${lowerNamespace}NamespaceURI);\n";
+ print F "DEFINE_GLOBAL(QualifiedName, ", $name, "Tag, nullAtom, \"$name\", ${lowerNamespace}NamespaceURI)\n";
}
print F "\n\nWebCore::QualifiedName** get$parameters{namespace}Tags(size_t* size)\n";
@@ -644,7 +644,7 @@
if (keys %allAttrs) {
print F "\n// Attributes\n";
for my $name (sort keys %allAttrs) {
- print F "DEFINE_GLOBAL(QualifiedName, ", $name, "Attr, nullAtom, \"$name\", ${lowerNamespace}NamespaceURI);\n";
+ print F "DEFINE_GLOBAL(QualifiedName, ", $name, "Attr, nullAtom, \"$name\", ${lowerNamespace}NamespaceURI)\n";
}
print F "\n\nWebCore::QualifiedName** get$parameters{namespace}Attrs(size_t* size)\n";
print F "{\n static WebCore::QualifiedName* $parameters{namespace}Attr[] = {\n";
