Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 281754ebdf08e0a1f7aa6f9c4efc5d838568348c
https://github.com/WebKit/WebKit/commit/281754ebdf08e0a1f7aa6f9c4efc5d838568348c
Author: Zak Ridouh <[email protected]>
Date: 2026-03-12 (Thu, 12 Mar 2026)
Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/http/tests/site-isolation/resources/select-element.html
A
LayoutTests/http/tests/site-isolation/select-in-cross-origin-iframe-expected.txt
A LayoutTests/http/tests/site-isolation/select-in-cross-origin-iframe.html
M LayoutTests/platform/ios/TestExpectations
M Source/WebKit/Shared/FocusedElementInformation.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
M Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm
M Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm
Log Message:
-----------
[Site Isolation] [iOS] <select> controls are broken when inside a
cross-origin iframe on iOS
https://bugs.webkit.org/show_bug.cgi?id=307911
rdar://164540344
Reviewed by Aditya Keerthi.
The UIMenu appears, but selecting a value does not update the value of the
input.
Skip the test on macOS due to lack of test infrastructure to choose a select
option outside of iOS.
A different patch will focus on the macOS side of things.
* LayoutTests/TestExpectations:
* LayoutTests/http/tests/site-isolation/resources/select-element.html: Added.
*
LayoutTests/http/tests/site-isolation/select-in-cross-origin-iframe-expected.txt:
Added.
* LayoutTests/http/tests/site-isolation/select-in-cross-origin-iframe.html:
Added.
* LayoutTests/platform/ios/TestExpectations:
* Source/WebKit/Shared/FocusedElementInformation.h:
(WebKit::FocusedElementInformation::frameID const):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView updateFocusedElementValue:]):
(-[WKContentView updateFocusedElementValueAsColor:]):
(-[WKContentView updateFocusedElementSelectedIndex:allowsMultipleSelection:]):
(-[WKContentView insertTextSuggestion:]):
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::setFocusedElementValue):
(WebKit::WebPageProxy::setFocusedElementSelectedIndex):
(WebKit::WebPageProxy::setSelectElementIsOpen):
* Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:
(-[WKDateTimePicker datePickerPopoverControllerDidReset:]):
* Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKSelectPicker
contextMenuInteraction:willDisplayMenuForConfiguration:animator:]):
(-[WKSelectPicker contextMenuInteraction:willEndForConfiguration:animator:]):
(-[WKSelectPicker resetContextMenuPresenter]):
Canonical link: https://commits.webkit.org/309172@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
