Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2b63f089635250898e4484cba790bc8accfe3bfa
https://github.com/WebKit/WebKit/commit/2b63f089635250898e4484cba790bc8accfe3bfa
Author: David Kilzer <[email protected]>
Date: 2026-03-13 (Fri, 13 Mar 2026)
Changed paths:
M Source/WebKit/DerivedSources-output.xcfilelist
M Source/WebKit/DerivedSources.make
M Tools/Scripts/extract-dependencies-from-makefile
Log Message:
-----------
Sandbox .sb files are not regenerated when switching between ASan and
non-ASan builds
<https://bugs.webkit.org/show_bug.cgi?id=309649>
<rdar://151774355>
Reviewed by Elliott Williams.
Add a stamp file dependency to the `%.sb` pattern rule in
DerivedSources.make so that sandbox profiles are regenerated when
`SANITIZE_FLAGS` changes. The `.sanitize-flags.stamp` file tracks
the current value of `SANITIZE_FLAGS` and only updates its timestamp
when the value changes, triggering regeneration of affected `.sb`
files.
* Source/WebKit/DerivedSources-output.xcfilelist:
- Add `.sanitize-flags.stamp` as a declared build output.
* Source/WebKit/DerivedSources.make:
- Use `$(shell ...)` to update `.sanitize-flags.stamp` at Makefile
parse time when `SANITIZE_FLAGS` value changes, avoiding `.PHONY`
which would cause Make to always rebuild dependents.
- Add `$(SANITIZE_FLAGS_STAMP)` as an explicit prerequisite of only
the sandbox profiles that use `ASAN_ENABLED`.
* Tools/Scripts/extract-dependencies-from-makefile:
- Exclude `.sanitize-flags.stamp` from the input xcfilelist so it
is not declared as an Xcode build input. Doing so would create a
cyclic dependency since the file is also included in the output
xcfilelist.
Canonical link: https://commits.webkit.org/309211@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
