Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 580476f19e152765b1eab13f8520fc134ff8e6c8
https://github.com/WebKit/WebKit/commit/580476f19e152765b1eab13f8520fc134ff8e6c8
Author: Rupin Mittal <[email protected]>
Date: 2026-03-13 (Fri, 13 Mar 2026)
Changed paths:
M LayoutTests/http/tests/mime/html-with-nosniff-html.html
M LayoutTests/http/tests/mime/svg-with-html.html
M LayoutTests/http/tests/mime/xhtml-with-html-with-content-disposition.html
M LayoutTests/http/tests/mime/xhtml-with-html.html
M LayoutTests/http/tests/mime/xml-with-html.html
M LayoutTests/platform/ios-site-isolation/TestExpectations
M LayoutTests/platform/mac-site-isolation/TestExpectations
Log Message:
-----------
[Site Isolation] 5x MIME tests are failing
https://bugs.webkit.org/show_bug.cgi?id=309818
rdar://172399213
Reviewed by Sihui Liu.
With site isolation on, neither the expected resource response or console log
are
printed out.
This is because when setting the onerror callback, testRunner.notifyDone() is
being
called immediately rather than being assigned as a callback. Site isolation
likely
introduces some overhead that causes the resource response and console log to
take
longer than with site isolation off. The test finishes before they can be
printed.
Same as: https://commits.webkit.org/309149@main
After this change, mime/html-with-nosniff-html.html still times out. In fact,
with
this change, the test times out even with site isolation is off.
In this test, because the Content-Type is empty and we cannot sniff the MIME
type,
the MIME type is defaulted to application/octet-stream. WebPage::canShowResponse
says that we cannot show this data, and so the WebProcess is told to ignore this
load, and the load then is cancelled. Neither the onload nor the onerror handler
is called. The way this test is written, it cannot complete.
To fix this, we change the test to complete once the main document has finished
loading. This will wait for the iframe's load to be cancelled.
* LayoutTests/http/tests/mime/html-with-nosniff-html.html:
* LayoutTests/http/tests/mime/svg-with-html.html:
* LayoutTests/http/tests/mime/xhtml-with-html-with-content-disposition.html:
* LayoutTests/http/tests/mime/xhtml-with-html.html:
* LayoutTests/http/tests/mime/xml-with-html.html:
* LayoutTests/platform/ios-site-isolation/TestExpectations:
* LayoutTests/platform/mac-site-isolation/TestExpectations:
Canonical link: https://commits.webkit.org/309215@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
