Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 56cc13187e5f21f382f3000825f30450e8034dcd
https://github.com/WebKit/WebKit/commit/56cc13187e5f21f382f3000825f30450e8034dcd
Author: Phinehas Fuachie <[email protected]>
Date: 2026-03-13 (Fri, 13 Mar 2026)
Changed paths:
M Source/WebKit/UIProcess/ios/WKExtrinsicButton.mm
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
Log Message:
-----------
[visionOS] Fullscreen left-side buttons should scale with Dynamic Type
https://bugs.webkit.org/show_bug.cgi?id=309491
rdar://172071503
Reviewed by Andy Estes.
The cancel, PiP, and more actions buttons in the fullscreen UI used a fixed
44x44 extrinsic content
size, which prevented them from scaling with Dynamic Type. This was
inconsistent with the View
Immersive button, which already scales correctly in compact mode.
- Use UIImageSymbolConfiguration with UIFontTextStyleBody for the button images
in the alternate
(visionOS) design path, so they scale with Dynamic Type.
- Stop setting a fixed extrinsicContentSize on these buttons in the alternate
path, letting them
size naturally via UIButtonConfiguration.
- Fix WKExtrinsicButton's intrinsicContentSize to fall through to super when no
extrinsic size has
been set, instead of returning CGSizeZero.
- Extract _updateButtonImages helper to avoid duplicating image configuration
code between loadView
and _contentSizeCategoryDidChange:.
- Move _contentSizeCategoryDidChange: outside the LINEAR_MEDIA_PLAYER guard
since it now also
updates the left-side buttons.
* Source/WebKit/UIProcess/ios/WKExtrinsicButton.mm:
(-[WKExtrinsicButton intrinsicContentSize]):
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController initWithWebView:]):
(-[WKFullScreenViewController _updateButtonImages]):
(-[WKFullScreenViewController _contentSizeCategoryDidChange:]):
(-[WKFullScreenViewController _setTopButtonLabel:]):
(-[WKFullScreenViewController loadView]):
Canonical link: https://commits.webkit.org/309221@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
