Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4ccdbebd68c709165088f1300fc13a58432da4ff
https://github.com/WebKit/WebKit/commit/4ccdbebd68c709165088f1300fc13a58432da4ff
Author: Chris Dumez <[email protected]>
Date: 2026-03-14 (Sat, 14 Mar 2026)
Changed paths:
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/bindings/js/JSIntersectionObserverCustom.cpp
M Source/WebCore/page/IntersectionObserver.cpp
M Source/WebCore/page/IntersectionObserver.h
Log Message:
-----------
Use `const Ref` for IntersectionObserver::m_callback
https://bugs.webkit.org/show_bug.cgi?id=309955
Reviewed by Geoffrey Garen and Anne van Kesteren.
Mark the data member as const as the code in
JSIntersectionObserver::visitAdditionalChildrenInGCThread()
would not be safe if this member was ever modified. Also use Ref instead
of RefPtr since it can never be null.
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebCore/bindings/js/JSIntersectionObserverCustom.cpp:
(WebCore::JSIntersectionObserver::visitAdditionalChildrenInGCThread):
* Source/WebCore/page/IntersectionObserver.cpp:
(WebCore::IntersectionObserver::observe):
(WebCore::IntersectionObserver::nowTimestamp const):
* Source/WebCore/page/IntersectionObserver.h:
(WebCore::IntersectionObserver::callbackConcurrently):
Canonical link: https://commits.webkit.org/309278@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
