Title: [114422] trunk
- Revision
- 114422
- Author
- commit-qu...@webkit.org
- Date
- 2012-04-17 13:05:57 -0700 (Tue, 17 Apr 2012)
Log Message
EFL's LayoutTestController does not implement callShouldCloseOnWebView
https://bugs.webkit.org/show_bug.cgi?id=82301
Patch by Christophe Dumez <christophe.du...@intel.com> on 2012-04-17
Reviewed by Martin Robinson.
Source/WebKit/efl:
Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related
test to be removed from the skip list.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related test
to be removed from the skip list.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::callShouldCloseOnWebView):
LayoutTests:
Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related test
to be removed from the skip list.
* platform/efl/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (114421 => 114422)
--- trunk/LayoutTests/ChangeLog 2012-04-17 20:05:22 UTC (rev 114421)
+++ trunk/LayoutTests/ChangeLog 2012-04-17 20:05:57 UTC (rev 114422)
@@ -1,5 +1,18 @@
2012-04-17 Christophe Dumez <christophe.du...@intel.com>
+ EFL's LayoutTestController does not implement callShouldCloseOnWebView
+ https://bugs.webkit.org/show_bug.cgi?id=82301
+
+ Reviewed by Martin Robinson.
+
+ Implement callShouldCloseOnWebView in EFL's LayoutTestController by
+ calling shouldClose() on the FrameLoader, allowing the related test
+ to be removed from the skip list.
+
+ * platform/efl/Skipped:
+
+2012-04-17 Christophe Dumez <christophe.du...@intel.com>
+
[EFL] FrameLoaderClient should send "load,finished" signal for all frame, not just the main one
https://bugs.webkit.org/show_bug.cgi?id=84052
Modified: trunk/LayoutTests/platform/efl/Skipped (114421 => 114422)
--- trunk/LayoutTests/platform/efl/Skipped 2012-04-17 20:05:22 UTC (rev 114421)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-04-17 20:05:57 UTC (rev 114422)
@@ -621,9 +621,6 @@
# EFL's LayoutTestController does not implement removeAllVisitedLinks
http/tests/globalhistory/history-delegate-basic-visited-links.html
-# EFL's LayoutTestController does not implement callShouldCloseOnWebView
-fast/events/onbeforeunload-focused-iframe.html
-
# EFL's LayoutTestController does not implement shadowPseudoId
fullscreen/video-controls-override.html
media/audio-delete-while-step-button-clicked.html
Modified: trunk/Source/WebKit/efl/ChangeLog (114421 => 114422)
--- trunk/Source/WebKit/efl/ChangeLog 2012-04-17 20:05:22 UTC (rev 114421)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-04-17 20:05:57 UTC (rev 114422)
@@ -1,5 +1,20 @@
2012-04-17 Christophe Dumez <christophe.du...@intel.com>
+ EFL's LayoutTestController does not implement callShouldCloseOnWebView
+ https://bugs.webkit.org/show_bug.cgi?id=82301
+
+ Reviewed by Martin Robinson.
+
+ Implement callShouldCloseOnWebView in EFL's LayoutTestController by
+ calling shouldClose() on the FrameLoader, allowing the related
+ test to be removed from the skip list.
+
+ * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+ (DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
+ * WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
+2012-04-17 Christophe Dumez <christophe.du...@intel.com>
+
[EFL] FrameLoaderClient should send "load,finished" signal for all frame, not just the main one
https://bugs.webkit.org/show_bug.cgi?id=84052
Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp (114421 => 114422)
--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp 2012-04-17 20:05:22 UTC (rev 114421)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp 2012-04-17 20:05:57 UTC (rev 114422)
@@ -63,6 +63,16 @@
return animationController->numberOfActiveAnimations(frame->document());
}
+bool DumpRenderTreeSupportEfl::callShouldCloseOnWebView(Evas_Object* ewkFrame)
+{
+ WebCore::Frame* frame = EWKPrivate::coreFrame(ewkFrame);
+
+ if (!frame)
+ return false;
+
+ return frame->loader()->shouldClose();
+}
+
void DumpRenderTreeSupportEfl::clearFrameName(Evas_Object* ewkFrame)
{
if (WebCore::Frame* frame = EWKPrivate::coreFrame(ewkFrame))
Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h (114421 => 114422)
--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h 2012-04-17 20:05:22 UTC (rev 114421)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h 2012-04-17 20:05:57 UTC (rev 114422)
@@ -45,6 +45,7 @@
~DumpRenderTreeSupportEfl() { }
static unsigned activeAnimationsCount(const Evas_Object* ewkFrame);
+ static bool callShouldCloseOnWebView(Evas_Object* ewkFrame);
static void clearFrameName(Evas_Object* ewkFrame);
static void clearOpener(Evas_Object* ewkFrame);
static String counterValueByElementId(const Evas_Object* ewkFrame, const char* elementId);
Modified: trunk/Tools/ChangeLog (114421 => 114422)
--- trunk/Tools/ChangeLog 2012-04-17 20:05:22 UTC (rev 114421)
+++ trunk/Tools/ChangeLog 2012-04-17 20:05:57 UTC (rev 114422)
@@ -1,3 +1,17 @@
+2012-04-17 Christophe Dumez <christophe.du...@intel.com>
+
+ EFL's LayoutTestController does not implement callShouldCloseOnWebView
+ https://bugs.webkit.org/show_bug.cgi?id=82301
+
+ Reviewed by Martin Robinson.
+
+ Implement callShouldCloseOnWebView in EFL's LayoutTestController by
+ calling shouldClose() on the FrameLoader, allowing the related test
+ to be removed from the skip list.
+
+ * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+ (LayoutTestController::callShouldCloseOnWebView):
+
2012-04-17 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
[EFL] Add setting API to enable/disable XSSAuditor
Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (114421 => 114422)
--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-04-17 20:05:22 UTC (rev 114421)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-04-17 20:05:57 UTC (rev 114422)
@@ -701,8 +701,7 @@
bool LayoutTestController::callShouldCloseOnWebView()
{
- notImplemented();
- return false;
+ return DumpRenderTreeSupportEfl::callShouldCloseOnWebView(browser->mainFrame());
}
void LayoutTestController::apiTestNewWindowDataLoadBaseURL(JSStringRef, JSStringRef)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
