Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 297f976adf7c77f3736be308a888cabb50abc03e
https://github.com/WebKit/WebKit/commit/297f976adf7c77f3736be308a888cabb50abc03e
Author: Ahmad Saleem <[email protected]>
Date: 2026-03-17 (Tue, 17 Mar 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/svg/animations/invalid-attribute-type-does-not-block-begin-event-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/svg/animations/invalid-attribute-type-does-not-block-begin-event.html
A
LayoutTests/imported/w3c/web-platform-tests/svg/animations/invalid-attribute-type-does-not-block-other-animations-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/svg/animations/invalid-attribute-type-does-not-block-other-animations.html
A
LayoutTests/imported/w3c/web-platform-tests/svg/animations/invalid-attribute-type-does-not-block-same-group-animation-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/svg/animations/invalid-attribute-type-does-not-block-same-group-animation.html
M Source/WebCore/svg/animation/SMILTimeContainer.cpp
Log Message:
-----------
[SVG] Invalid attribute type in one animation group prevents all subsequent
animation groups from running
https://bugs.webkit.org/show_bug.cgi?id=309976
rdar://172593109
Reviewed by Said Abou-Hallawa.
SMILTimeContainer::updateAnimations() used return instead of continue when
encountering an animation group whose first animation had an invalid
attribute type. This caused the entire function to exit, preventing all
subsequent animation groups from being processed, their events from
being dispatched, and the animation timer from being restarted.
Without this fix, we timeout on one of below tests while fail another.
Added another test based on Said's input for subsequent animation.
* Source/WebCore/svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::updateAnimations):
*
LayoutTests/imported/w3c/web-platform-tests/svg/animations/invalid-attribute-type-does-not-block-begin-event-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/animations/invalid-attribute-type-does-not-block-begin-event.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/animations/invalid-attribute-type-does-not-block-other-animations-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/animations/invalid-attribute-type-does-not-block-other-animations.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/animations/invalid-attribute-type-does-not-block-same-group-animation-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/animations/invalid-attribute-type-does-not-block-same-group-animation.html:
Added.
Canonical link: https://commits.webkit.org/309436@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
