Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0059c82f9dd9e8dc5779de33bebd99e625956be2
https://github.com/WebKit/WebKit/commit/0059c82f9dd9e8dc5779de33bebd99e625956be2
Author: Claudio Saavedra <[email protected]>
Date: 2026-03-18 (Wed, 18 Mar 2026)
Changed paths:
M Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp
Log Message:
-----------
[GTK] fast/forms/implicit-submit.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=310099
Reviewed by Carlos Garcia Campos.
hidePopupMenu() has a reentrancy issue, in that its gtk_popover_popdown()
call will trigger a GtkPopover:closed emission that will reenter
hidePopupMenu(),
causing it to be removed from its parent before the parent call to
gtk_popover_popdown() has finished, which will cause a dangling object
to be used.
This can be tentatively fixed by disconnecting the handlers in hidePopupMenu()
directly, instead of cancelTracking(). Not verified locally as I can't reproduce
the crash.
* Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::hidePopupMenu):
(WebKit::WebPopupMenuProxyGtk::cancelTracking):
Canonical link: https://commits.webkit.org/309468@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
