Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 18dd142a5ae79c3aef10fdaff68c0f878ce97f8e
https://github.com/WebKit/WebKit/commit/18dd142a5ae79c3aef10fdaff68c0f878ce97f8e
Author: Taher Ali <[email protected]>
Date: 2026-03-18 (Wed, 18 Mar 2026)
Changed paths:
A
LayoutTests/css3/filters/reference-filter-update-invalidates-cache-expected.html
A LayoutTests/css3/filters/reference-filter-update-invalidates-cache.html
A LayoutTests/css3/filters/reference-filter-update-to-invalid-expected.html
A LayoutTests/css3/filters/reference-filter-update-to-invalid.html
A LayoutTests/css3/filters/reference-filter-update-to-noop-expected.html
A LayoutTests/css3/filters/reference-filter-update-to-noop.html
M Source/WebCore/rendering/ReferencedSVGResources.cpp
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayer.h
Log Message:
-----------
CSS filter referencing SVG filter not invalidated when filter content changes
https://bugs.webkit.org/show_bug.cgi?id=247397
rdar://101870430
Reviewed by Said Abou-Hallawa.
When an SVG filter element's content is dynamically modified (via innerHTML),
elements using that filter through CSS `filter: url(#id)` don't visually update.
RenderLayerFilters caches the built CSSFilterRenderer and only rebuilds
it when geometry or compositing mode changes. Since a filter content
change doesn't alter geometry, the repaint reuses the stale cached filter.
The fix invalidates the cached CSSFilterRenderer when resource changes.
*
LayoutTests/css3/filters/reference-filter-update-invalidates-cache-expected.html:
Added.
* LayoutTests/css3/filters/reference-filter-update-invalidates-cache.html:
Added.
* LayoutTests/css3/filters/reference-filter-update-to-invalid-expected.html:
Added.
* LayoutTests/css3/filters/reference-filter-update-to-invalid.html: Added.
* LayoutTests/css3/filters/reference-filter-update-to-noop-expected.html: Added.
* LayoutTests/css3/filters/reference-filter-update-to-noop.html: Added.
* Source/WebCore/rendering/ReferencedSVGResources.cpp:
(WebCore::CSSSVGResourceElementClient::resourceChanged):
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):
* Source/WebCore/rendering/RenderLayer.h:
Canonical link: https://commits.webkit.org/309495@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
