Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5f9b7987023287301f4330756c11dac9fc9435d8
https://github.com/WebKit/WebKit/commit/5f9b7987023287301f4330756c11dac9fc9435d8
Author: Cole Carley <[email protected]>
Date: 2026-03-18 (Wed, 18 Mar 2026)
Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/dom/FragmentDirectiveRangeFinder.cpp
A Source/WebCore/editing/ICUSearcher.cpp
A Source/WebCore/editing/ICUSearcher.h
M Source/WebCore/editing/InsertTextCommand.cpp
M Source/WebCore/editing/ModifySelectionListLevel.cpp
M Source/WebCore/editing/SpellChecker.cpp
M Source/WebCore/editing/TextIterator.cpp
M Source/WebCore/editing/TextIterator.h
M Source/WebCore/editing/TextManipulationItem.h
M Source/WebCore/page/text-extraction/TextExtraction.cpp
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Log Message:
-----------
Move unrelated code out of TextIterator
https://bugs.webkit.org/show_bug.cgi?id=310147
rdar://172786702
Reviewed by Brent Fulgham and Ryosuke Niwa.
There are a lot of helper functions in TextIterator.cpp that could
be moved into it's own file.
This change also allows other clients to use some of these helper
functions.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/FragmentDirectiveRangeFinder.cpp:
* Source/WebCore/editing/TextIterator.cpp:
(WebCore::SearchBuffer::SearchBuffer):
(WebCore::SearchBuffer::reachedBreak):
(WebCore::SearchBuffer::search):
(WebCore::foldQuoteMarkAndReplaceNoBreakSpace): Deleted.
(WebCore::foldQuoteMarks): Deleted.
(WebCore::createSearcher): Deleted.
(WebCore::searcher): Deleted.
(WebCore::lockSearcher): Deleted.
(WebCore::unlockSearcher): Deleted.
(WebCore::isKanaLetter): Deleted.
(WebCore::isSmallKanaLetter): Deleted.
(WebCore::composedVoicedSoundMark): Deleted.
(WebCore::isCombiningVoicedSoundMark): Deleted.
(WebCore::containsKanaLetters): Deleted.
(WebCore::normalizeCharacters): Deleted.
(WebCore::isNonLatin1Separator): Deleted.
(WebCore::isSeparator): Deleted.
(WebCore::SearchBuffer::~SearchBuffer): Deleted.
(WebCore::SearchBuffer::isBadMatch const): Deleted.
(WebCore::SearchBuffer::isWordEndMatch const): Deleted.
(WebCore::SearchBuffer::isWordStartMatch const): Deleted.
* Source/WebCore/editing/TextIterator.h:
* Source/WebCore/editing/TextSearchICU.cpp: Added.
(WebCore::createSearcher):
(WebCore::globalSearcher):
(WebCore::ICUSearcher::ICUSearcher):
(WebCore::ICUSearcher::~ICUSearcher):
(WebCore::ICUSearcher::lock):
(WebCore::ICUSearcher::unlock):
(WebCore::ICUSearcher::reset):
(WebCore::ICUSearcher::searcher):
(WebCore::isBadMatch):
(WebCore::isWordStartMatch):
(WebCore::isWordEndMatch):
(WebCore::normalizeCharacters):
(WebCore::foldQuoteMarkAndReplaceNoBreakSpace):
(WebCore::isSeparator):
(WebCore::containsKanaLetters):
(WebCore::foldQuoteMarks):
(WebCore::isKanaLetter):
(WebCore::isSmallKanaLetter):
(WebCore::composedVoicedSoundMark):
(WebCore::isCombiningVoicedSoundMark):
(WebCore::isNonLatin1Separator):
* Source/WebCore/editing/TextSearchICU.h: Added.
* Source/WebCore/page/text-extraction/TextExtraction.cpp:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
Canonical link: https://commits.webkit.org/309514@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
