Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c5cdc14ccf8df858900838efd606b8984e7a90f3
https://github.com/WebKit/WebKit/commit/c5cdc14ccf8df858900838efd606b8984e7a90f3
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-03-20 (Fri, 20 Mar 2026)
Changed paths:
M Tools/Scripts/webkitdirs.pm
Log Message:
-----------
[WPE][GTK] Ensure that jhbuild or flatpak is only used if set explicitly via
WEBKIT_JHBUILD=1 or WEBKIT_FLATPAK=1 (follow-up patch)
https://bugs.webkit.org/show_bug.cgi?id=310187
Unreviewed follow-up patch.
The refactor in 309557@main that moved the update logic from update-webkit*-libs
into webkitdirs.pm introduced a bug: the function could fall through the initial
if/elsif chain and enter the final if block, for example printing the wkdev-sdk
warning even after a successful run of update-webkit-libs-jhbuild.
Fix this by replacing system() with exec() so each branch is final: the Perl
process is replaced by the child program and never returns to the caller.
The `or die` guards on each exec() catch failures such as a missing script.
* Tools/Scripts/webkitdirs.pm:
(updateGtkOrWpeLibs):
Canonical link: https://commits.webkit.org/309613@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
