Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f4f384ccff9af49ceafa8352c6f8fbeb865cef3c
https://github.com/WebKit/WebKit/commit/f4f384ccff9af49ceafa8352c6f8fbeb865cef3c
Author: Elliott Williams <[email protected]>
Date: 2026-03-20 (Fri, 20 Mar 2026)
Changed paths:
M Tools/CISupport/ews-build/config.json
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/loadConfig.py
M Tools/CISupport/ews-build/loadConfig_unittest.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[EWS] Recognize a macOS deployment target config parameter for back-deployed
builds
https://bugs.webkit.org/show_bug.cgi?id=307195
rdar://151877838
Reviewed by Ryan Haddad.
In EWS, add an optional `deployment_target` field to config.json. Store
it as a property of the build and plumb it through to the build-webkit
line, where it is used to override the MACOSX_DEPLOYMENT_TARGET build
setting.
When deployment target is set, use it to perform the builder/tester
configuration check, instead of comparing OS and Xcode version. Testers
must be running an OS version that is at least as recent as the
deployment target, in the same major release.
Set the deployment target for the existing Sequoia queues.
* Tools/CISupport/ews-build/config.json:
* Tools/CISupport/ews-build/factories.py:
(Factory.__init__):
(BuildFactory.__init__):
(CommitQueueFactory.__init__):
(MergeQueueFactoryBase.__init__):
* Tools/CISupport/ews-build/loadConfig.py:
(loadBuilderConfig):
* Tools/CISupport/ews-build/loadConfig_unittest.py:
(ConfigDotJSONTest.test_builder_keys):
(ConfigDotJSONTest.test_deployment_target_on_intended_queues):
* Tools/CISupport/ews-build/steps.py:
(ConfigureBuild.__init__):
(ConfigureBuild.run):
(Trigger.propertiesToPassToTriggers):
(CompileWebKit.run):
(PrintConfiguration.parseAndValidate):
* Tools/CISupport/ews-build/steps_unittest.py:
(BuildStepMixinAdditions.fakeStopBuild):
(BuildStepMixinAdditions.setup_step): Add a callable stopBuild() to
FakeBuild which does nothing. The test checks the state set by
buildFinished(). AFAICT, the FakeBuild + FakeMaster do not establish
enough internal state for the native build interruption logic to work.
Canonical link: https://commits.webkit.org/309626@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
