Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8220ffea7d8bec59de1a8b90b3b09ca0e053cb0a
https://github.com/WebKit/WebKit/commit/8220ffea7d8bec59de1a8b90b3b09ca0e053cb0a
Author: Geoffrey Garen <[email protected]>
Date: 2026-03-23 (Mon, 23 Mar 2026)
Changed paths:
M Tools/Scripts/webkitpy/style/checkers/swift.py
M Tools/Scripts/webkitpy/style/checkers/swift_unittest.py
Log Message:
-----------
Style checker should warn about unsafe/@safe in Swift files
https://bugs.webkit.org/show_bug.cgi?id=310316
rdar://172956774
Reviewed by Richard Robinson.
Swift is a multi-paradigm language that does not dogmatically require memory
safety.
This check will remind engineers that upholding Strict Safety is our goal in
WebKit.
* Tools/Scripts/webkitpy/style/checkers/swift.py:
(SwiftChecker._swift_format):
(SwiftChecker._check_unsafe):
(SwiftChecker.check):
(SwiftChecker._process_lines): Deleted.
* Tools/Scripts/webkitpy/style/checkers/swift_unittest.py:
(SwiftCheckerTest.test_check):
(SwiftCheckerTest):
(SwiftCheckerTest.test_check_unsafe):
(SwiftCheckerTest.test_check_unsafe._mock_handle_style_error):
(SwiftCheckerTest.test_check_safe):
(SwiftCheckerTest.test_check_safe._mock_handle_style_error):
Canonical link: https://commits.webkit.org/309774@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications