Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 201f3c005a3b21e2413a904d0591014e3370cc4a
https://github.com/WebKit/WebKit/commit/201f3c005a3b21e2413a904d0591014e3370cc4a
Author: Júlio Piubello <[email protected]>
Date: 2026-03-23 (Mon, 23 Mar 2026)
Changed paths:
M Source/WebKit/UIProcess/Automation/BidiBrowsingContextAgent.cpp
M Source/WebKit/UIProcess/Automation/BidiBrowsingContextAgent.h
M Source/WebKit/UIProcess/Automation/protocol/BidiBrowsingContext.json
M WebDriverTests/TestExpectations.json
Log Message:
-----------
[WebDriver][BiDi] Fix browsingContext.navigate invalid parameter handling
https://bugs.webkit.org/show_bug.cgi?id=288330
Reviewed by Devin Rousso.
The BiDi WPT invalid parameter tests for browsingContext.navigate expect
unknown browsing context ids (including "") to map to "no such frame", and
invalid wait values (including "") to map to "invalid argument".
This change maps unknown browsing context handles to FrameNotFound, and
treats the optional wait parameter as a string so we can reject invalid
provided values instead of silently defaulting.
Test: ./Tools/Scripts/run-webdriver-tests --gtk
WebDriverTests/imported/w3c/webdriver/tests/bidi/browsing_context/navigate/invalid.py
* Source/WebKit/UIProcess/Automation/BidiBrowsingContextAgent.cpp:
(WebKit::BidiBrowsingContextAgent::navigate): Use FrameNotFound for unknown
contexts and validate optional wait strings.
* Source/WebKit/UIProcess/Automation/BidiBrowsingContextAgent.h:
(WebKit::BidiBrowsingContextAgent::navigate): Updated signature for optional
wait string.
* Source/WebKit/UIProcess/Automation/protocol/BidiBrowsingContext.json:
Modeled navigate.wait as an optional string.
* WebDriverTests/TestExpectations.json:
Removed now-passing expectations for navigate/invalid.py tests.
Canonical link: https://commits.webkit.org/309780@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
