Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 92179a19a0f189ff7ddcf0e1d2792804b65653d3
https://github.com/WebKit/WebKit/commit/92179a19a0f189ff7ddcf0e1d2792804b65653d3
Author: Adrian Perez de Castro <[email protected]>
Date: 2026-03-24 (Tue, 24 Mar 2026)
Changed paths:
M Source/WebCore/html/HTMLLinkElement.cpp
M Source/WebCore/html/HTMLTemplateElement.cpp
M Source/WebCore/html/ImageBitmap.cpp
M Source/WebCore/html/shadow/SelectFallbackButtonElement.cpp
M Source/WebCore/loader/LinkLoader.cpp
M Source/WebCore/page/ContextMenuController.cpp
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/platform/audio/MediaSessionManagerInterface.cpp
M Source/WebCore/testing/MockCaptionDisplaySettingsClientCallback.idl
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp
M Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
M Source/WebKit/WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp
M Source/cmake/GStreamerChecks.cmake
M Source/cmake/GStreamerDefinitions.cmake
M Source/cmake/GStreamerDependencies.cmake
M Source/cmake/WebKitFeatures.cmake
Log Message:
-----------
[CMake][GStreamer] Allow toggling USE_GSTREAMER to disable all multimedia
support
https://bugs.webkit.org/show_bug.cgi?id=310634
Reviewed by Philippe Normand.
Make USE_GSTREAMER an actual option, and make features which require
GStreamer depend on it, and fix the build with USE_GSTREAMER=OFF.
* Source/WebCore/html/HTMLLinkElement.cpp: Fix includes due to shift in
translation units for unified builds.
* Source/WebCore/html/HTMLTemplateElement.cpp: Ditto.
* Source/WebCore/html/ImageBitmap.cpp: Ditto.
* Source/WebCore/html/shadow/SelectFallbackButtonElement.cpp: Ditto.
* Source/WebCore/loader/LinkLoader.cpp: Ditto.
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):
Remove unneeded ENABLE(VIDEO) guard.
* Source/WebCore/page/Quirks.cpp: Add missing ENABLE(VIDEO) guard.
* Source/WebCore/platform/audio/MediaSessionManagerInterface.cpp:
(WebCore::MediaSessionManagerInterface::addSession): Add missing
UNUSED_PARAM() when ENABLE(VIDEO) is disabled.
* Source/WebCore/testing/MockCaptionDisplaySettingsClientCallback.idl:
Make the interface depend on ENABLE_VIDEO.
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Add
missing ENABLE(VIDEO) guard.
* Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp: Add
missing CStringView.h inclusion, remove CString.h
* Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp: Ditto.
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: Ditto.
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::performEnterFullScreen): Add missing
ENABLE(VIDEO) guard.
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetCaptionDisplayMode): Fix variable name in usage of
UNUSED_PARAM() macro.
(WKBundlePageCreateCaptionUserPreferencesTestingModeToken): Ditto.
* Source/WebKit/WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp:
(WebKit::createShareableBitmapAsync): Add missing ENABLE(VIDEO) guard.
* Source/cmake/GStreamerChecks.cmake:
* Source/cmake/GStreamerDefinitions.cmake: Add USE_GSTREAMER as a
recognized build option.
* Source/cmake/GStreamerDependencies.cmake: Make features which need
GStreamer depend on USE_GSTREAMER.
* Source/cmake/WebKitFeatures.cmake: When disabling options due to
dependencies, make set() change cache values, otherwise variables
previously defined with a different default value e.g. using option()
would never get their value changed. While at it, turn macros
_WEBKIT_OPTION_ENFORCE_DEPENDS() and _WEBKIT_OPTION_ENFORCE_ALL_DEPENDS()
into functions, as they do not need to be macros.
Canonical link: https://commits.webkit.org/309883@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
