Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 41489acc0d94daedb1921a1ec2ffc7ef1ebaac22
https://github.com/WebKit/WebKit/commit/41489acc0d94daedb1921a1ec2ffc7ef1ebaac22
Author: Simon Pena <[email protected]>
Date: 2026-03-26 (Thu, 26 Mar 2026)
Changed paths:
M Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
A Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner_unittest.py
M Tools/Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.2.1.plan
M Tools/Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.3.1.plan
M Tools/Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.3.plan
Log Message:
-----------
[run-benchmark] Restore support to run MotionMark subtests
https://bugs.webkit.org/show_bug.cgi?id=310633
Reviewed by Carlos Alberto Lopez Perez.
Add a leading & to MotionMark subtest_url_formats, so that when combined
creating a subset of tests they result in a valid URL. Added a note in
the code building the URL, to hint that plans need to stay up to date.
Added a new unit test that loads MotionMark, Speedometer and JetStream
plans to confirm that subtests can be properly formed.
* Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner._construct_subtest_url):
* Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner_unittest.py: Added.
(MockRunner):
(MockRunner.__init__):
(ConstructSubtestURLTest):
(ConstructSubtestURLTest._load_plan):
(ConstructSubtestURLTest._construct):
(ConstructSubtestURLTest.test_no_subtests_returns_empty):
(ConstructSubtestURLTest.test_empty_subtests_returns_empty):
(ConstructSubtestURLTest.test_no_format_in_plan_returns_empty):
(ConstructSubtestURLTest.test_speedometer_single_subtest):
(ConstructSubtestURLTest.test_speedometer_multiple_subtests):
(ConstructSubtestURLTest.test_motionmark_single_subtest):
(ConstructSubtestURLTest.test_motionmark_multiple_subtests):
(ConstructSubtestURLTest.test_jetstream_single_subtest):
(ConstructSubtestURLTest.test_jetstream_multiple_subtests):
* Tools/Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.2.1.plan:
* Tools/Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.3.1.plan:
* Tools/Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.3.plan:
Canonical link: https://commits.webkit.org/309974@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
