Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e40f40eb41b53217438005958dc4faaf7d937224
      
https://github.com/WebKit/WebKit/commit/e40f40eb41b53217438005958dc4faaf7d937224
  Author: Carlos Garcia Campos <[email protected]>
  Date:   2026-03-26 (Thu, 26 Mar 2026)

  Changed paths:
    M 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AcceleratedSurface.cpp
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AcceleratedSurface.h

  Log Message:
  -----------
  [GTK][WPE] Simplify AcceleratedSurface by making SwapChain and RenderTarget 
keep a weak reference to the surface
https://bugs.webkit.org/show_bug.cgi?id=310818

Reviewed by Nikolas Zimmermann.

This simplifies the initialization of the swap chain that can be done in
the constructor. This patch also changes m_backgroundColor to be
std::optional<WebCore::Color> which is what we get from WebPage and
makes it easier to check whether it's opaque. This refactoring is
also in preparion for a follow up to change the way we handle the skia
surface in non-composited mode.

* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AcceleratedSurface.cpp:
(WebKit::AcceleratedSurface::create):
(WebKit::AcceleratedSurface::AcceleratedSurface):
(WebKit::AcceleratedSurface::RenderTarget::RenderTarget):
(WebKit::AcceleratedSurface::RenderTargetShareableBuffer::RenderTargetShareableBuffer):
(WebKit::AcceleratedSurface::RenderTargetShareableBuffer::~RenderTargetShareableBuffer):
(WebKit::AcceleratedSurface::RenderTargetShareableBuffer::sendFrame):
(WebKit::AcceleratedSurface::RenderTargetEGLImage::create):
(WebKit::AcceleratedSurface::RenderTargetEGLImage::RenderTargetEGLImage):
(WebKit::AcceleratedSurface::RenderTargetSHMImage::create):
(WebKit::AcceleratedSurface::RenderTargetSHMImage::RenderTargetSHMImage):
(WebKit::AcceleratedSurface::RenderTargetSHMImageWithoutGL::create):
(WebKit::AcceleratedSurface::RenderTargetSHMImageWithoutGL::RenderTargetSHMImageWithoutGL):
(WebKit::AcceleratedSurface::RenderTargetSHMImageWithoutGL::~RenderTargetSHMImageWithoutGL):
(WebKit::AcceleratedSurface::RenderTargetSHMImageWithoutGL::sendFrame):
(WebKit::AcceleratedSurface::RenderTargetTexture::create):
(WebKit::AcceleratedSurface::RenderTargetTexture::RenderTargetTexture):
(WebKit::AcceleratedSurface::RenderTargetWPEBackend::create):
(WebKit::AcceleratedSurface::RenderTargetWPEBackend::RenderTargetWPEBackend):
(WebKit::AcceleratedSurface::SwapChain::SwapChain):
(WebKit::AcceleratedSurface::SwapChain::setupBufferFormat):
(WebKit::AcceleratedSurface::SwapChain::createTarget const):
(WebKit::AcceleratedSurface::SwapChain::nextTarget):
(WebKit::AcceleratedSurface::SwapChain::reset):
(WebKit::AcceleratedSurface::SwapChain::releaseUnusedBuffers):
(WebKit::AcceleratedSurface::SwapChain::window const):
(WebKit::AcceleratedSurface::preferredBufferFormatsDidChange):
(WebKit::AcceleratedSurface::backgroundColorDidChange):
(WebKit::AcceleratedSurface::window const):
(WebKit::AcceleratedSurface::isOpaque const):
(WebKit::AcceleratedSurface::clear):
(WebKit::isColorOpaque): Deleted.
(WebKit::AcceleratedSurface::SwapChain::initialize): Deleted.
(WebKit::AcceleratedSurface::SwapChain::initializeTarget): Deleted.
(WebKit::AcceleratedSurface::surfaceID const): Deleted.
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AcceleratedSurface.h:

Canonical link: https://commits.webkit.org/310006@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to