Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5bb1dce804788fb9f01bd6f5f71d64bef3047911
https://github.com/WebKit/WebKit/commit/5bb1dce804788fb9f01bd6f5f71d64bef3047911
Author: Ahmad Saleem <[email protected]>
Date: 2026-03-26 (Thu, 26 Mar 2026)
Changed paths:
R
LayoutTests/platform/mac/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-combinations-expected.txt
R
LayoutTests/platform/mac/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-expected.txt
M Tools/TestRunnerShared/cocoa/ModifierKeys.mm
Log Message:
-----------
Add leftMeta/rightMeta key handling to ModifierKeys on macOS
https://bugs.webkit.org/show_bug.cgi?id=310784
rdar://173386914
Reviewed by Lily Spiniolas and Abrar Rahman Protyasha.
ModifierKeys.mm handled leftControl, leftShift, leftAlt and their right
variants but was missing leftMeta/rightMeta. When testdriver-vendor.js
mapped WebDriver key code 0xE03D to 'leftMeta' and passed it to
eventSender, the key name wasn't recognized, leaving keyCode at 0 and
characters as the literal string "leftMeta". This caused
PlatformEventFactoryMac::keyForKeyEvent() to miss the kVK_Command check
and return "leftMeta" as the DOM event.key value instead of "Meta".
* Tools/TestRunnerShared/cocoa/ModifierKeys.mm:
(+[ModifierKeys modifierKeysWithKey:modifiers:keyLocation:]):
> Removed platform specific expectations since now we pass last failing:
*
LayoutTests/platform/mac/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-combinations-expected.txt:
Removed.
*
LayoutTests/platform/mac/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-expected.txt:
Removed.
Canonical link: https://commits.webkit.org/310014@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
