Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 08e77559836eb722e6f6dc13e7e04ea8cbe01c53
https://github.com/WebKit/WebKit/commit/08e77559836eb722e6f6dc13e7e04ea8cbe01c53
Author: Carlos Garcia Campos <[email protected]>
Date: 2026-03-26 (Thu, 26 Mar 2026)
Changed paths:
M
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AcceleratedSurface.cpp
M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AcceleratedSurface.h
M
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/NonCompositedFrameRenderer.cpp
Log Message:
-----------
[GTK][WPE] Do not use external frame buffer for non-composited mode
https://bugs.webkit.org/show_bug.cgi?id=310827
Reviewed by Nikolas Zimmermann.
Instead of using the frame buffer and create a SkSurface wrapping it,
use a texture and create a SkSurface wrapping it. This simplifies the
code and allows skia to create its own frame buffer. Instead of creating
the skia surface on demand when asked, it's now created at construction
when rendering mode is non-composited one. This patch removes
RenderTargetSHMImageWithoutGL since we can use RenderTargetSHMImage that
creates the skia surface only for non-composited mode.
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AcceleratedSurface.cpp:
(WebKit::AcceleratedSurface::RenderTarget::createSkiaSurfaceForTexture):
(WebKit::AcceleratedSurface::RenderTargetShareableBuffer::RenderTargetShareableBuffer):
(WebKit::AcceleratedSurface::RenderTargetShareableBuffer::willRenderFrame):
(WebKit::AcceleratedSurface::RenderTargetShareableBuffer::sync):
(WebKit::AcceleratedSurface::RenderTargetEGLImage::RenderTargetEGLImage):
(WebKit::AcceleratedSurface::RenderTargetSHMImage::RenderTargetSHMImage):
(WebKit::AcceleratedSurface::RenderTargetSHMImage::didRenderFrame):
(WebKit::AcceleratedSurface::RenderTargetTexture::create):
(WebKit::AcceleratedSurface::RenderTargetTexture::RenderTargetTexture):
(WebKit::AcceleratedSurface::SwapChain::SwapChain):
(WebKit::AcceleratedSurface::SwapChain::createTarget const):
(WebKit::AcceleratedSurface::canvas):
(WebKit::AcceleratedSurface::willRenderFrame):
(WebKit::AcceleratedSurface::clear):
(WebKit::AcceleratedSurface::didRenderFrame):
(WebKit::AcceleratedSurface::RenderTargetShareableBuffer::skiaSurface): Deleted.
(WebKit::AcceleratedSurface::RenderTargetSHMImageWithoutGL::create): Deleted.
(WebKit::AcceleratedSurface::RenderTargetSHMImageWithoutGL::RenderTargetSHMImageWithoutGL):
Deleted.
(WebKit::AcceleratedSurface::RenderTargetSHMImageWithoutGL::~RenderTargetSHMImageWithoutGL):
Deleted.
(WebKit::AcceleratedSurface::RenderTargetSHMImageWithoutGL::skiaSurface):
Deleted.
(WebKit::AcceleratedSurface::RenderTargetSHMImageWithoutGL::sendFrame): Deleted.
(WebKit::AcceleratedSurface::RenderTargetTexture::~RenderTargetTexture):
Deleted.
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AcceleratedSurface.h:
*
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/NonCompositedFrameRenderer.cpp:
(WebKit::NonCompositedFrameRenderer::updateRendering):
Canonical link: https://commits.webkit.org/310053@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
