Title: [114519] trunk/Source/WebCore
Revision
114519
Author
[email protected]
Date
2012-04-18 09:53:46 -0700 (Wed, 18 Apr 2012)

Log Message

[V8] Add an optional Isolate argument to wrap()
https://bugs.webkit.org/show_bug.cgi?id=84202

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch adds an optional Isolate argument to wrap().
After rewriting all wrap() callers so that they pass Isolate
to wrap(), I'll make the Isolate argument non-optional.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm: Modified as described above.
(GenerateHeader):
* bindings/v8/custom/V8DocumentCustom.cpp: Ditto.
(WebCore::toV8):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp: Ditto.
(WebCore::toV8):
* bindings/v8/custom/V8NodeCustom.cpp: Ditto.
(WebCore::toV8Slow):
* bindings/v8/custom/V8SVGDocumentCustom.cpp: Ditto.
(WebCore::toV8):
* dom/make_names.pl: Ditto.
(printWrapperFactoryCppFile):

* bindings/scripts/test/V8/V8Float64Array.h:
Updated run-bindings-tests results.
(V8Float64Array):
(WebCore::V8Float64Array::wrap):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (114518 => 114519)


--- trunk/Source/WebCore/ChangeLog	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/ChangeLog	2012-04-18 16:53:46 UTC (rev 114519)
@@ -1,3 +1,75 @@
+2012-04-17  Kentaro Hara  <[email protected]>
+
+        [V8] Add an optional Isolate argument to wrap()
+        https://bugs.webkit.org/show_bug.cgi?id=84202
+
+        Reviewed by Nate Chapin.
+
+        The final objective is to pass Isolate around in V8 bindings.
+        This patch adds an optional Isolate argument to wrap().
+        After rewriting all wrap() callers so that they pass Isolate
+        to wrap(), I'll make the Isolate argument non-optional.
+
+        No tests. No change in behavior.
+
+        * bindings/scripts/CodeGeneratorV8.pm: Modified as described above.
+        (GenerateHeader):
+        * bindings/v8/custom/V8DocumentCustom.cpp: Ditto.
+        (WebCore::toV8):
+        * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Ditto.
+        (WebCore::toV8):
+        * bindings/v8/custom/V8NodeCustom.cpp: Ditto.
+        (WebCore::toV8Slow):
+        * bindings/v8/custom/V8SVGDocumentCustom.cpp: Ditto.
+        (WebCore::toV8):
+        * dom/make_names.pl: Ditto.
+        (printWrapperFactoryCppFile):
+
+        * bindings/scripts/test/V8/V8Float64Array.h:
+        Updated run-bindings-tests results.
+        (V8Float64Array):
+        (WebCore::V8Float64Array::wrap):
+        * bindings/scripts/test/V8/V8TestActiveDOMObject.h:
+        (V8TestActiveDOMObject):
+        (WebCore::V8TestActiveDOMObject::wrap):
+        (WebCore::toV8):
+        * bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
+        (V8TestCustomNamedGetter):
+        (WebCore::V8TestCustomNamedGetter::wrap):
+        (WebCore::toV8):
+        * bindings/scripts/test/V8/V8TestEventConstructor.h:
+        (V8TestEventConstructor):
+        (WebCore::V8TestEventConstructor::wrap):
+        (WebCore::toV8):
+        * bindings/scripts/test/V8/V8TestEventTarget.h:
+        (V8TestEventTarget):
+        (WebCore::V8TestEventTarget::wrap):
+        (WebCore::toV8):
+        * bindings/scripts/test/V8/V8TestInterface.h:
+        (V8TestInterface):
+        (WebCore::V8TestInterface::wrap):
+        (WebCore::toV8):
+        * bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
+        (V8TestMediaQueryListListener):
+        (WebCore::V8TestMediaQueryListListener::wrap):
+        (WebCore::toV8):
+        * bindings/scripts/test/V8/V8TestNamedConstructor.h:
+        (V8TestNamedConstructor):
+        (WebCore::V8TestNamedConstructor::wrap):
+        (WebCore::toV8):
+        * bindings/scripts/test/V8/V8TestNode.h:
+        (V8TestNode):
+        (WebCore::V8TestNode::wrap):
+        (WebCore::toV8):
+        * bindings/scripts/test/V8/V8TestObj.h:
+        (V8TestObj):
+        (WebCore::V8TestObj::wrap):
+        (WebCore::toV8):
+        * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
+        (V8TestSerializedScriptValueInterface):
+        (WebCore::V8TestSerializedScriptValueInterface::wrap):
+        (WebCore::toV8):
+
 2012-04-18  Alexandru Chiculita  <[email protected]>
 
         [CSS Filters] Do not use clipping rect when calculating the bounds of a layer

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (114518 => 114519)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-04-18 16:53:46 UTC (rev 114519)
@@ -327,7 +327,7 @@
     {
         return reinterpret_cast<${nativeType}*>(object->GetPointerFromInternalField(v8DOMWrapperObjectIndex));
     }
-    inline static v8::Handle<v8::Object> wrap(${nativeType}*${forceNewObjectParameter});
+    inline static v8::Handle<v8::Object> wrap(${nativeType}*, v8::Isolate* = 0${forceNewObjectParameter});
     static void derefObject(void*);
     static WrapperTypeInfo info;
 END
@@ -420,7 +420,7 @@
 END
 
     push(@headerContent, <<END);
-v8::Handle<v8::Object> ${className}::wrap(${nativeType}* impl${forceNewObjectInput})
+v8::Handle<v8::Object> ${className}::wrap(${nativeType}* impl, v8::Isolate* isolate${forceNewObjectInput})
 {
 END
     push(@headerContent, "    if (!forceNewObject) {\n") if IsDOMNodeType($interfaceName);
@@ -445,13 +445,13 @@
 {
     if (!impl)
         return v8::Null();
-    return ${className}::wrap(impl${forceNewObjectCall});
+    return ${className}::wrap(impl, isolate${forceNewObjectCall});
 }
 END
     } elsif ($interfaceName ne 'Node') {
         push(@headerContent, <<END);
 
-v8::Handle<v8::Value> toV8(${nativeType}*, v8::Isolate* isolate = 0${forceNewObjectParameter});
+v8::Handle<v8::Value> toV8(${nativeType}*, v8::Isolate* = 0${forceNewObjectParameter});
 END
     } else {
         push(@headerContent, <<END);

Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.h (114518 => 114519)


--- trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.h	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.h	2012-04-18 16:53:46 UTC (rev 114519)
@@ -41,7 +41,7 @@
     {
         return reinterpret_cast<Float64Array*>(object->GetPointerFromInternalField(v8DOMWrapperObjectIndex));
     }
-    inline static v8::Handle<v8::Object> wrap(Float64Array*);
+    inline static v8::Handle<v8::Object> wrap(Float64Array*, v8::Isolate* = 0);
     static void derefObject(void*);
     static WrapperTypeInfo info;
     static v8::Handle<v8::Value> constructorCallback(const v8::Arguments&);
@@ -50,7 +50,7 @@
     static v8::Handle<v8::Object> wrapSlow(PassRefPtr<Float64Array>);
 };
 
-v8::Handle<v8::Object> V8Float64Array::wrap(Float64Array* impl)
+v8::Handle<v8::Object> V8Float64Array::wrap(Float64Array* impl, v8::Isolate* isolate)
 {
         v8::Handle<v8::Object> wrapper = getDOMObjectMap().get(impl);
         if (!wrapper.IsEmpty())
@@ -58,7 +58,7 @@
     return V8Float64Array::wrapSlow(impl);
 }
 
-v8::Handle<v8::Value> toV8(Float64Array*, v8::Isolate* isolate = 0);
+v8::Handle<v8::Value> toV8(Float64Array*, v8::Isolate* = 0);
 inline v8::Handle<v8::Value> toV8(PassRefPtr< Float64Array > impl, v8::Isolate* isolate = 0)
 {
     return toV8(impl.get(), isolate);

Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h (114518 => 114519)


--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h	2012-04-18 16:53:46 UTC (rev 114519)
@@ -40,7 +40,7 @@
     {
         return reinterpret_cast<TestActiveDOMObject*>(object->GetPointerFromInternalField(v8DOMWrapperObjectIndex));
     }
-    inline static v8::Handle<v8::Object> wrap(TestActiveDOMObject*);
+    inline static v8::Handle<v8::Object> wrap(TestActiveDOMObject*, v8::Isolate* = 0);
     static void derefObject(void*);
     static WrapperTypeInfo info;
     static const int internalFieldCount = v8DefaultWrapperInternalFieldCount + 0;
@@ -50,7 +50,7 @@
     static v8::Handle<v8::Object> wrapSlow(PassRefPtr<TestActiveDOMObject>);
 };
 
-v8::Handle<v8::Object> V8TestActiveDOMObject::wrap(TestActiveDOMObject* impl)
+v8::Handle<v8::Object> V8TestActiveDOMObject::wrap(TestActiveDOMObject* impl, v8::Isolate* isolate)
 {
         v8::Handle<v8::Object> wrapper = getDOMObjectMap().get(impl);
         if (!wrapper.IsEmpty())
@@ -62,7 +62,7 @@
 {
     if (!impl)
         return v8::Null();
-    return V8TestActiveDOMObject::wrap(impl);
+    return V8TestActiveDOMObject::wrap(impl, isolate);
 }
 inline v8::Handle<v8::Value> toV8(PassRefPtr< TestActiveDOMObject > impl, v8::Isolate* isolate = 0)
 {

Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h (114518 => 114519)


--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h	2012-04-18 16:53:46 UTC (rev 114519)
@@ -40,7 +40,7 @@
     {
         return reinterpret_cast<TestCustomNamedGetter*>(object->GetPointerFromInternalField(v8DOMWrapperObjectIndex));
     }
-    inline static v8::Handle<v8::Object> wrap(TestCustomNamedGetter*);
+    inline static v8::Handle<v8::Object> wrap(TestCustomNamedGetter*, v8::Isolate* = 0);
     static void derefObject(void*);
     static WrapperTypeInfo info;
     static v8::Handle<v8::Value> namedPropertyGetter(v8::Local<v8::String>, const v8::AccessorInfo&);
@@ -49,7 +49,7 @@
     static v8::Handle<v8::Object> wrapSlow(PassRefPtr<TestCustomNamedGetter>);
 };
 
-v8::Handle<v8::Object> V8TestCustomNamedGetter::wrap(TestCustomNamedGetter* impl)
+v8::Handle<v8::Object> V8TestCustomNamedGetter::wrap(TestCustomNamedGetter* impl, v8::Isolate* isolate)
 {
         v8::Handle<v8::Object> wrapper = getDOMObjectMap().get(impl);
         if (!wrapper.IsEmpty())
@@ -61,7 +61,7 @@
 {
     if (!impl)
         return v8::Null();
-    return V8TestCustomNamedGetter::wrap(impl);
+    return V8TestCustomNamedGetter::wrap(impl, isolate);
 }
 inline v8::Handle<v8::Value> toV8(PassRefPtr< TestCustomNamedGetter > impl, v8::Isolate* isolate = 0)
 {

Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h (114518 => 114519)


--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h	2012-04-18 16:53:46 UTC (rev 114519)
@@ -41,7 +41,7 @@
     {
         return reinterpret_cast<TestEventConstructor*>(object->GetPointerFromInternalField(v8DOMWrapperObjectIndex));
     }
-    inline static v8::Handle<v8::Object> wrap(TestEventConstructor*);
+    inline static v8::Handle<v8::Object> wrap(TestEventConstructor*, v8::Isolate* = 0);
     static void derefObject(void*);
     static WrapperTypeInfo info;
     static v8::Handle<v8::Value> constructorCallback(const v8::Arguments&);
@@ -50,7 +50,7 @@
     static v8::Handle<v8::Object> wrapSlow(PassRefPtr<TestEventConstructor>);
 };
 
-v8::Handle<v8::Object> V8TestEventConstructor::wrap(TestEventConstructor* impl)
+v8::Handle<v8::Object> V8TestEventConstructor::wrap(TestEventConstructor* impl, v8::Isolate* isolate)
 {
         v8::Handle<v8::Object> wrapper = getDOMObjectMap().get(impl);
         if (!wrapper.IsEmpty())
@@ -62,7 +62,7 @@
 {
     if (!impl)
         return v8::Null();
-    return V8TestEventConstructor::wrap(impl);
+    return V8TestEventConstructor::wrap(impl, isolate);
 }
 inline v8::Handle<v8::Value> toV8(PassRefPtr< TestEventConstructor > impl, v8::Isolate* isolate = 0)
 {

Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h (114518 => 114519)


--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h	2012-04-18 16:53:46 UTC (rev 114519)
@@ -40,7 +40,7 @@
     {
         return reinterpret_cast<TestEventTarget*>(object->GetPointerFromInternalField(v8DOMWrapperObjectIndex));
     }
-    inline static v8::Handle<v8::Object> wrap(TestEventTarget*);
+    inline static v8::Handle<v8::Object> wrap(TestEventTarget*, v8::Isolate* = 0);
     static void derefObject(void*);
     static WrapperTypeInfo info;
     static v8::Handle<v8::Value> indexedPropertyGetter(uint32_t, const v8::AccessorInfo&);
@@ -51,7 +51,7 @@
     static v8::Handle<v8::Object> wrapSlow(PassRefPtr<TestEventTarget>);
 };
 
-v8::Handle<v8::Object> V8TestEventTarget::wrap(TestEventTarget* impl)
+v8::Handle<v8::Object> V8TestEventTarget::wrap(TestEventTarget* impl, v8::Isolate* isolate)
 {
         v8::Handle<v8::Object> wrapper = getDOMObjectMap().get(impl);
         if (!wrapper.IsEmpty())
@@ -63,7 +63,7 @@
 {
     if (!impl)
         return v8::Null();
-    return V8TestEventTarget::wrap(impl);
+    return V8TestEventTarget::wrap(impl, isolate);
 }
 inline v8::Handle<v8::Value> toV8(PassRefPtr< TestEventTarget > impl, v8::Isolate* isolate = 0)
 {

Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h (114518 => 114519)


--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h	2012-04-18 16:53:46 UTC (rev 114519)
@@ -42,7 +42,7 @@
     {
         return reinterpret_cast<TestInterface*>(object->GetPointerFromInternalField(v8DOMWrapperObjectIndex));
     }
-    inline static v8::Handle<v8::Object> wrap(TestInterface*);
+    inline static v8::Handle<v8::Object> wrap(TestInterface*, v8::Isolate* = 0);
     static void derefObject(void*);
     static WrapperTypeInfo info;
     static ActiveDOMObject* toActiveDOMObject(v8::Handle<v8::Object>);
@@ -53,7 +53,7 @@
     static v8::Handle<v8::Object> wrapSlow(PassRefPtr<TestInterface>);
 };
 
-v8::Handle<v8::Object> V8TestInterface::wrap(TestInterface* impl)
+v8::Handle<v8::Object> V8TestInterface::wrap(TestInterface* impl, v8::Isolate* isolate)
 {
         v8::Handle<v8::Object> wrapper = getActiveDOMObjectMap().get(impl);
         if (!wrapper.IsEmpty())
@@ -65,7 +65,7 @@
 {
     if (!impl)
         return v8::Null();
-    return V8TestInterface::wrap(impl);
+    return V8TestInterface::wrap(impl, isolate);
 }
 inline v8::Handle<v8::Value> toV8(PassRefPtr< TestInterface > impl, v8::Isolate* isolate = 0)
 {

Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h (114518 => 114519)


--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h	2012-04-18 16:53:46 UTC (rev 114519)
@@ -40,7 +40,7 @@
     {
         return reinterpret_cast<TestMediaQueryListListener*>(object->GetPointerFromInternalField(v8DOMWrapperObjectIndex));
     }
-    inline static v8::Handle<v8::Object> wrap(TestMediaQueryListListener*);
+    inline static v8::Handle<v8::Object> wrap(TestMediaQueryListListener*, v8::Isolate* = 0);
     static void derefObject(void*);
     static WrapperTypeInfo info;
     static const int internalFieldCount = v8DefaultWrapperInternalFieldCount + 0;
@@ -48,7 +48,7 @@
     static v8::Handle<v8::Object> wrapSlow(PassRefPtr<TestMediaQueryListListener>);
 };
 
-v8::Handle<v8::Object> V8TestMediaQueryListListener::wrap(TestMediaQueryListListener* impl)
+v8::Handle<v8::Object> V8TestMediaQueryListListener::wrap(TestMediaQueryListListener* impl, v8::Isolate* isolate)
 {
         v8::Handle<v8::Object> wrapper = getDOMObjectMap().get(impl);
         if (!wrapper.IsEmpty())
@@ -60,7 +60,7 @@
 {
     if (!impl)
         return v8::Null();
-    return V8TestMediaQueryListListener::wrap(impl);
+    return V8TestMediaQueryListListener::wrap(impl, isolate);
 }
 inline v8::Handle<v8::Value> toV8(PassRefPtr< TestMediaQueryListListener > impl, v8::Isolate* isolate = 0)
 {

Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h (114518 => 114519)


--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h	2012-04-18 16:53:46 UTC (rev 114519)
@@ -46,7 +46,7 @@
     {
         return reinterpret_cast<TestNamedConstructor*>(object->GetPointerFromInternalField(v8DOMWrapperObjectIndex));
     }
-    inline static v8::Handle<v8::Object> wrap(TestNamedConstructor*);
+    inline static v8::Handle<v8::Object> wrap(TestNamedConstructor*, v8::Isolate* = 0);
     static void derefObject(void*);
     static WrapperTypeInfo info;
     static ActiveDOMObject* toActiveDOMObject(v8::Handle<v8::Object>);
@@ -55,7 +55,7 @@
     static v8::Handle<v8::Object> wrapSlow(PassRefPtr<TestNamedConstructor>);
 };
 
-v8::Handle<v8::Object> V8TestNamedConstructor::wrap(TestNamedConstructor* impl)
+v8::Handle<v8::Object> V8TestNamedConstructor::wrap(TestNamedConstructor* impl, v8::Isolate* isolate)
 {
         v8::Handle<v8::Object> wrapper = getActiveDOMObjectMap().get(impl);
         if (!wrapper.IsEmpty())
@@ -67,7 +67,7 @@
 {
     if (!impl)
         return v8::Null();
-    return V8TestNamedConstructor::wrap(impl);
+    return V8TestNamedConstructor::wrap(impl, isolate);
 }
 inline v8::Handle<v8::Value> toV8(PassRefPtr< TestNamedConstructor > impl, v8::Isolate* isolate = 0)
 {

Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h (114518 => 114519)


--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h	2012-04-18 16:53:46 UTC (rev 114519)
@@ -40,7 +40,7 @@
     {
         return reinterpret_cast<TestNode*>(object->GetPointerFromInternalField(v8DOMWrapperObjectIndex));
     }
-    inline static v8::Handle<v8::Object> wrap(TestNode*);
+    inline static v8::Handle<v8::Object> wrap(TestNode*, v8::Isolate* = 0);
     static void derefObject(void*);
     static WrapperTypeInfo info;
     static v8::Handle<v8::Value> constructorCallback(const v8::Arguments&);
@@ -49,7 +49,7 @@
     static v8::Handle<v8::Object> wrapSlow(PassRefPtr<TestNode>);
 };
 
-v8::Handle<v8::Object> V8TestNode::wrap(TestNode* impl)
+v8::Handle<v8::Object> V8TestNode::wrap(TestNode* impl, v8::Isolate* isolate)
 {
         v8::Handle<v8::Object> wrapper = V8DOMWrapper::getCachedWrapper(impl);
         if (!wrapper.IsEmpty())
@@ -61,7 +61,7 @@
 {
     if (!impl)
         return v8::Null();
-    return V8TestNode::wrap(impl);
+    return V8TestNode::wrap(impl, isolate);
 }
 inline v8::Handle<v8::Value> toV8(PassRefPtr< TestNode > impl, v8::Isolate* isolate = 0)
 {

Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h (114518 => 114519)


--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h	2012-04-18 16:53:46 UTC (rev 114519)
@@ -40,7 +40,7 @@
     {
         return reinterpret_cast<TestObj*>(object->GetPointerFromInternalField(v8DOMWrapperObjectIndex));
     }
-    inline static v8::Handle<v8::Object> wrap(TestObj*);
+    inline static v8::Handle<v8::Object> wrap(TestObj*, v8::Isolate* = 0);
     static void derefObject(void*);
     static WrapperTypeInfo info;
     static v8::Handle<v8::Value> customMethodCallback(const v8::Arguments&);
@@ -54,7 +54,7 @@
     static v8::Handle<v8::Object> wrapSlow(PassRefPtr<TestObj>);
 };
 
-v8::Handle<v8::Object> V8TestObj::wrap(TestObj* impl)
+v8::Handle<v8::Object> V8TestObj::wrap(TestObj* impl, v8::Isolate* isolate)
 {
         v8::Handle<v8::Object> wrapper = getDOMObjectMap().get(impl);
         if (!wrapper.IsEmpty())
@@ -66,7 +66,7 @@
 {
     if (!impl)
         return v8::Null();
-    return V8TestObj::wrap(impl);
+    return V8TestObj::wrap(impl, isolate);
 }
 inline v8::Handle<v8::Value> toV8(PassRefPtr< TestObj > impl, v8::Isolate* isolate = 0)
 {

Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h (114518 => 114519)


--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h	2012-04-18 16:53:46 UTC (rev 114519)
@@ -42,7 +42,7 @@
     {
         return reinterpret_cast<TestSerializedScriptValueInterface*>(object->GetPointerFromInternalField(v8DOMWrapperObjectIndex));
     }
-    inline static v8::Handle<v8::Object> wrap(TestSerializedScriptValueInterface*);
+    inline static v8::Handle<v8::Object> wrap(TestSerializedScriptValueInterface*, v8::Isolate* = 0);
     static void derefObject(void*);
     static WrapperTypeInfo info;
     static v8::Handle<v8::Value> constructorCallback(const v8::Arguments&);
@@ -51,7 +51,7 @@
     static v8::Handle<v8::Object> wrapSlow(PassRefPtr<TestSerializedScriptValueInterface>);
 };
 
-v8::Handle<v8::Object> V8TestSerializedScriptValueInterface::wrap(TestSerializedScriptValueInterface* impl)
+v8::Handle<v8::Object> V8TestSerializedScriptValueInterface::wrap(TestSerializedScriptValueInterface* impl, v8::Isolate* isolate)
 {
         v8::Handle<v8::Object> wrapper = getDOMObjectMap().get(impl);
         if (!wrapper.IsEmpty())
@@ -63,7 +63,7 @@
 {
     if (!impl)
         return v8::Null();
-    return V8TestSerializedScriptValueInterface::wrap(impl);
+    return V8TestSerializedScriptValueInterface::wrap(impl, isolate);
 }
 inline v8::Handle<v8::Value> toV8(PassRefPtr< TestSerializedScriptValueInterface > impl, v8::Isolate* isolate = 0)
 {

Modified: trunk/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp (114518 => 114519)


--- trunk/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp	2012-04-18 16:53:46 UTC (rev 114519)
@@ -126,7 +126,7 @@
     if (impl->isSVGDocument())
         return toV8(static_cast<SVGDocument*>(impl), isolate, forceNewObject);
 #endif
-    v8::Handle<v8::Object> wrapper = V8Document::wrap(impl, forceNewObject);
+    v8::Handle<v8::Object> wrapper = V8Document::wrap(impl, isolate, forceNewObject);
     if (wrapper.IsEmpty())
         return wrapper;
     if (!V8IsolatedContext::getEntered()) {

Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp (114518 => 114519)


--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp	2012-04-18 16:53:46 UTC (rev 114519)
@@ -190,7 +190,7 @@
 {
     if (!impl)
         return v8::Null();
-    v8::Handle<v8::Object> wrapper = V8HTMLDocument::wrap(impl, forceNewObject);
+    v8::Handle<v8::Object> wrapper = V8HTMLDocument::wrap(impl, isolate, forceNewObject);
     if (wrapper.IsEmpty())
         return wrapper;
     if (!V8IsolatedContext::getEntered()) {

Modified: trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp (114518 => 114519)


--- trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp	2012-04-18 16:53:46 UTC (rev 114519)
@@ -154,7 +154,7 @@
         if (impl->isSVGElement())
             return toV8(static_cast<SVGElement*>(impl), isolate, forceNewObject);
 #endif
-        return V8Element::wrap(static_cast<Element*>(impl), forceNewObject);
+        return V8Element::wrap(static_cast<Element*>(impl), isolate, forceNewObject);
     case Node::ATTRIBUTE_NODE:
         return toV8(static_cast<Attr*>(impl), isolate, forceNewObject);
     case Node::TEXT_NODE:
@@ -179,6 +179,6 @@
         return toV8(static_cast<Notation*>(impl), isolate, forceNewObject);
     default: break; // XPATH_NAMESPACE_NODE
     }
-    return V8Node::wrap(impl, forceNewObject);
+    return V8Node::wrap(impl, isolate, forceNewObject);
 }
 } // namespace WebCore

Modified: trunk/Source/WebCore/bindings/v8/custom/V8SVGDocumentCustom.cpp (114518 => 114519)


--- trunk/Source/WebCore/bindings/v8/custom/V8SVGDocumentCustom.cpp	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/bindings/v8/custom/V8SVGDocumentCustom.cpp	2012-04-18 16:53:46 UTC (rev 114519)
@@ -42,7 +42,7 @@
 {
     if (!impl)
         return v8::Null();
-    v8::Handle<v8::Object> wrapper = V8SVGDocument::wrap(impl, forceNewObject);
+    v8::Handle<v8::Object> wrapper = V8SVGDocument::wrap(impl, isolate, forceNewObject);
     if (wrapper.IsEmpty())
         return wrapper;
     if (!V8IsolatedContext::getEntered()) {

Modified: trunk/Source/WebCore/dom/make_names.pl (114518 => 114519)


--- trunk/Source/WebCore/dom/make_names.pl	2012-04-18 16:34:32 UTC (rev 114518)
+++ trunk/Source/WebCore/dom/make_names.pl	2012-04-18 16:53:46 UTC (rev 114519)
@@ -1212,7 +1212,7 @@
     } elsif ($wrapperFactoryType eq "V8") {
         print F <<END
         return createWrapperFunction(element);
-    return V8$parameters{fallbackInterfaceName}::wrap(to$parameters{fallbackInterfaceName}(element), forceNewObject);
+    return V8$parameters{fallbackInterfaceName}::wrap(to$parameters{fallbackInterfaceName}(element), 0, forceNewObject);
 END
 ;
     }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to