Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 038aac1ed9186c24d78f37a5ff5abd169acba344
https://github.com/WebKit/WebKit/commit/038aac1ed9186c24d78f37a5ff5abd169acba344
Author: Brandon Stewart <[email protected]>
Date: 2026-03-30 (Mon, 30 Mar 2026)
Changed paths:
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
Log Message:
-----------
[Accessibility] Remove overly strict AX_ASSERT in
WebPage::inheritAccessibilityMode
https://bugs.webkit.org/show_bug.cgi?id=311126
rdar://173716198
Reviewed by BJ Burg and Tyler Wilcock.
Running the css/css-grid WPT tests in debug mode was causing numerous crashes.
The assertion assumed that if the UIProcess sends an Off accessibility mode
during WebPage creation,
accessibility must not already be enabled in the WebContent process. This
doesn't hold when multiple
WebPages share a process: an earlier page may have enabled accessibility
process-wide via a non-Off mode,
and a subsequent page receiving Off is normal.
The function already handles this correctly by returning early (no-op). The
assertion was purely defensive
and the crash it caused was worse than the silent no-op.
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::inheritAccessibilityMode):
Canonical link: https://commits.webkit.org/310276@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications