Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8c2cc6504c168761df1878632290de83f5c85ffd
https://github.com/WebKit/WebKit/commit/8c2cc6504c168761df1878632290de83f5c85ffd
Author: Kiet Ho <[email protected]>
Date: 2026-04-01 (Wed, 01 Apr 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-function-chain-pseudo-elements-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-function-chain-pseudo-elements.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-size-function-chain-pseudo-elements-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-size-function-chain-pseudo-elements-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-size-function-chain-pseudo-elements.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-chain-pseudo-elements-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-chain-pseudo-elements.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/pseudo-element-anchor-tree-order-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/pseudo-element-anchor-tree-order.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/reference/pseudo-element-chain-ref.html
M Source/WebCore/dom/BoundaryPoint.cpp
M Source/WebCore/dom/Node.cpp
M Source/WebCore/dom/Node.h
M Source/WebCore/dom/SimpleRange.cpp
M Source/WebCore/style/AnchorPositionEvaluator.cpp
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
Log Message:
-----------
[css-anchor-position-1] Accommodate pseudo-elements when sorting anchor
elements by tree order
rdar://173032203
https://bugs.webkit.org/show_bug.cgi?id=310398
Reviewed by Antti Koivisto.
When determining which element is the anchor, the last element in tree order
that satistifes
the anchor query wins [1]:
> If an ancestor of query el satisfies the following conditions, return the
> nearest such element
> to query el. Otherwise, return the last element el in tree order that
> satisfies the conditions.
WebKit implemented this by sorting anchors with the same anchor name in reverse
tree order,
using treeOrder<ComposedTree> to determine the order. But treeOrder doesn't
work with
pseudo-elements (e.g ::before, ::after). Fix this by extending treeOrder to
support pseudo-elements.
Tests:
imported/w3c/web-platform-tests/css/css-anchor-position/anchor-function-chain-pseudo-elements.html
imported/w3c/web-platform-tests/css/css-anchor-position/anchor-size-function-chain-pseudo-elements.html
imported/w3c/web-platform-tests/css/css-anchor-position/position-area-chain-pseudo-elements.html
imported/w3c/web-platform-tests/css/css-anchor-position/pseudo-element-anchor-tree-order.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-function-chain-pseudo-elements-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-function-chain-pseudo-elements.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-size-function-chain-pseudo-elements-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-size-function-chain-pseudo-elements-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-size-function-chain-pseudo-elements.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-chain-pseudo-elements-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-chain-pseudo-elements.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/pseudo-element-anchor-tree-order-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/pseudo-element-anchor-tree-order.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/reference/pseudo-element-chain-ref.html:
Added.
* Source/WebCore/dom/BoundaryPoint.cpp:
(WebCore::treeOrderForTesting):
* Source/WebCore/dom/Node.cpp:
(WebCore::parent<ComposedTreeIncludingPseudoElements>):
* Add a new TreeType called ComposedTreeIncludingPseudoElements. This is
similar to ComposedTree,
but parent<ComposedTreeIncludingPseudoElements> will traverse from a
pseudo-element to its host.
(WebCore::isSiblingSubsequent):
* Extend isSiblingSubsequent to sort ::before and ::after. ::before comes
before all other
elements, and ::after comes after all other elements.
* Make it generic over TreeType, so it can use parent<TreeType> to get the
node's parent.
parentNode() wouldn't work to get the host of pseudo-elements.
(WebCore::treeOrder):
(WebCore::treeOrderForTesting):
* Source/WebCore/dom/Node.h:
* Source/WebCore/dom/SimpleRange.cpp:
(WebCore::contains):
(WebCore::intersectsForTesting):
* Source/WebCore/style/AnchorPositionEvaluator.cpp:
(WebCore::Style::collectAnchorsForAnchorName):
* Use treeOrder<ComposedTreeIncludingPseudoElements> to sort the anchors.
* Source/WebCore/testing/Internals.cpp:
(WebCore::convertType):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
Canonical link: https://commits.webkit.org/310407@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
