Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 19c0606a3a33ce4d68d778ddc33ba6cc7cb8849a
https://github.com/WebKit/WebKit/commit/19c0606a3a33ce4d68d778ddc33ba6cc7cb8849a
Author: Matt Woodrow <[email protected]>
Date: 2026-04-01 (Wed, 01 Apr 2026)
Changed paths:
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm
M
Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h
M
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.h
M
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm
M
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.h
M
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm
Log Message:
-----------
MESSAGE_CHECK in
remoteScrollingCoordinatorProxyIOS::establishLayerTreeScrollingRelations.
https://bugs.webkit.org/show_bug.cgi?id=310763
<rdar://168807740>
Reviewed by Simon Fraser.
Scrolling tree state can cross frame boundaries, and relationships are only
valid once layer updates have been made to all frames.
Moves establishLayerTreeScrollingRelations to cross-platform code, since it's
valid to check everywhere, and fixes the MESSAGE_CHECKs to mark the correct
connection.
Moves the call to establishLayerTreeScrollingRelations to happen once after all
transactions from a given process have been applied, since it's not
per-transaction state.
I haven't figured out how to test this yet unfortunately.
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::commitScrollingTreeState):
(WebKit::RemoteScrollingCoordinatorProxy::establishLayerTreeScrollingRelations):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
*
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.h:
*
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:
(WebKit::RemoteScrollingCoordinatorProxyIOS::establishLayerTreeScrollingRelations):
Deleted.
*
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.h:
*
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm:
(WebKit::RemoteScrollingCoordinatorProxyMac::establishLayerTreeScrollingRelations):
Deleted.
Canonical link: https://commits.webkit.org/310408@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
