Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 750203030daadc77f3bc45b1a106677758f0f50c
https://github.com/WebKit/WebKit/commit/750203030daadc77f3bc45b1a106677758f0f50c
Author: Sergio Villar Senin <[email protected]>
Date: 2026-04-01 (Wed, 01 Apr 2026)
Changed paths:
M Source/WebCore/Modules/webxr/WebXRFrame.cpp
M Source/WebCore/Modules/webxr/WebXRInputSourceArray.cpp
M Source/WebCore/Modules/webxr/WebXRSession.cpp
M Source/WebCore/Modules/webxr/WebXRSystem.cpp
Log Message:
-----------
[WebXR][SaferCPP] Do not hide smart pointers behind auto
https://bugs.webkit.org/show_bug.cgi?id=311267
Reviewed by Mike Wyrzykowski and Dan Glastonbury.
As stated by the SaferCPP guidelines
https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines#do-not-hide-smart-pointers-behind-auto
we should not hide smart pointers behind auto in order to make pointer
semantics and lifetime management immediately visible.
No new tests required as we're just replacing types.
* Source/WebCore/Modules/webxr/WebXRFrame.cpp:
(WebCore::WebXRFrame::isLocalReferenceSpace const):
(WebCore::WebXRFrame::getViewerPose):
(WebCore::WebXRFrame::fillJointRadii):
(WebCore::WebXRFrame::fillPoses):
* Source/WebCore/Modules/webxr/WebXRInputSourceArray.cpp:
(WebCore::WebXRInputSourceArray::itemByHandle const):
(WebCore::WebXRInputSourceArray::update):
(WebCore::WebXRInputSourceArray::handleAddedOrUpdatedInputSources):
* Source/WebCore/Modules/webxr/WebXRSession.cpp:
(WebCore::WebXRSession::create):
(WebCore::WebXRSession::~WebXRSession):
(WebCore::WebXRSession::updateRenderState):
(WebCore::WebXRSession::referenceSpaceIsSupported const):
(WebCore::WebXRSession::requestReferenceSpace):
(WebCore::WebXRSession::recommendedWebGLFramebufferResolution const):
(WebCore::WebXRSession::supportsViewportScaling const):
(WebCore::WebXRSession::didCompleteShutdown):
(WebCore::WebXRSession::updateSessionVisibilityState):
(WebCore::WebXRSession::applyPendingRenderState):
(WebCore::WebXRSession::requestFrameIfNeeded):
(WebCore::WebXRSession::onFrame):
(WebCore::WebXRSession::cancelHitTestSource):
(WebCore::WebXRSession::cancelTransientInputHitTestSource):
(WebCore::WebXRSession::initializeTrackingAndRendering):
* Source/WebCore/Modules/webxr/WebXRSystem.cpp:
(WebCore::WebXRSystem::create):
(WebCore::WebXRSystem::ensureImmersiveXRDeviceIsSelected):
(WebCore::WebXRSystem::isSessionSupported):
(WebCore::WebXRSystem::isFeatureSupported const):
(WebCore::WebXRSystem::resolveFeaturePermissions const):
(WebCore::WebXRSystem::requestSession):
(WebCore::WebXRSystem::registerSimulatedXRDeviceForTesting):
(WebCore::WebXRSystem::unregisterSimulatedXRDeviceForTesting):
(WebCore::WebXRSystem::DummyInlineDevice::requestFrame):
Canonical link: https://commits.webkit.org/310423@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
