Title: [114541] trunk/Source/WebCore
- Revision
- 114541
- Author
- [email protected]
- Date
- 2012-04-18 11:46:57 -0700 (Wed, 18 Apr 2012)
Log Message
Unreviewed. Adding FIXME comment to FractionalLayoutUnit explaining the lack of size_t operators.
* platform/FractionalLayoutUnit.h:
(FractionalLayoutUnit):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (114540 => 114541)
--- trunk/Source/WebCore/ChangeLog 2012-04-18 18:40:30 UTC (rev 114540)
+++ trunk/Source/WebCore/ChangeLog 2012-04-18 18:46:57 UTC (rev 114541)
@@ -1,3 +1,10 @@
+2012-04-18 Emil A Eklund <[email protected]>
+
+ Unreviewed. Adding FIXME comment to FractionalLayoutUnit explaining the lack of size_t operators.
+
+ * platform/FractionalLayoutUnit.h:
+ (FractionalLayoutUnit):
+
2012-04-18 Benjamin Poulain <[email protected]>
Remove m_subclassData from JSArray, move the attribute to subclass as needed
Modified: trunk/Source/WebCore/platform/FractionalLayoutUnit.h (114540 => 114541)
--- trunk/Source/WebCore/platform/FractionalLayoutUnit.h 2012-04-18 18:40:30 UTC (rev 114540)
+++ trunk/Source/WebCore/platform/FractionalLayoutUnit.h 2012-04-18 18:46:57 UTC (rev 114541)
@@ -44,6 +44,10 @@
class FractionalLayoutUnit {
public:
+ // FIXME: Ideally we would have size_t versions of the constructor and operators.
+ // However due to compiler and platform differences adding those are non-trivial.
+ // See https://bugs.webkit.org/show_bug.cgi?id=83848 for details.
+
FractionalLayoutUnit() : m_value(0) { }
FractionalLayoutUnit(int value) { ASSERT(isInBounds(value)); m_value = value * kFixedPointDenominator; }
FractionalLayoutUnit(unsigned short value) { ASSERT(isInBounds(value)); m_value = value * kFixedPointDenominator; }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
