Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 595acc3c1f77e0d712990df8daf7c08f7e9839da
https://github.com/WebKit/WebKit/commit/595acc3c1f77e0d712990df8daf7c08f7e9839da
Author: Richard Robinson <[email protected]>
Date: 2026-04-02 (Thu, 02 Apr 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/VisibleContentRect.mm
M Tools/TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm
Log Message:
-----------
Fix some correctness issues for a few TestWebKitAPI tests
https://bugs.webkit.org/show_bug.cgi?id=311366
rdar://173964365
Reviewed by Tim Horton.
Both tests were always technically crashing because they were accessing
non-weak properties/variables,
but accidentally were passing because the test runner exited before the crash
actually happened.
Address `DoNotCrashWhenCallingTextInputClientMethodsWhileDeallocatingView` by
deleting it entirely, since it
is an invalid test that relied on accidental behavior of the test runner itself.
Fix the other test by using `weak`.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/VisibleContentRect.mm:
* Tools/TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm:
(TestWebKitAPI::TEST(WKWebViewMacEditingTests,
DoNotCrashWhenCallingTextInputClientMethodsWhileDeallocatingView)):
Canonical link: https://commits.webkit.org/310493@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
