Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6537092834b33e94c3052d36e6a6bd57eebbd145
https://github.com/WebKit/WebKit/commit/6537092834b33e94c3052d36e6a6bd57eebbd145
Author: Mike Wyrzykowski <[email protected]>
Date: 2026-04-06 (Mon, 06 Apr 2026)
Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WTF/wtf/PlatformEnable.h
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WTF/wtf/PlatformHave.h
M Source/WebCore/Configurations/WebCore.xcconfig
M Source/WebCore/Headers.cmake
M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
M Source/WebCore/Modules/model-element/HTMLModelElement.h
M Source/WebCore/Modules/model-element/HTMLModelElement.idl
M Source/WebCore/Modules/model-element/ModelPlayer.cpp
M Source/WebCore/Modules/model-element/ModelPlayer.h
R Source/WebCore/Modules/model-element/scenekit/SceneKitModel.h
R Source/WebCore/Modules/model-element/scenekit/SceneKitModel.mm
R Source/WebCore/Modules/model-element/scenekit/SceneKitModelLoader.h
R Source/WebCore/Modules/model-element/scenekit/SceneKitModelLoader.mm
R Source/WebCore/Modules/model-element/scenekit/SceneKitModelLoaderClient.h
R Source/WebCore/Modules/model-element/scenekit/SceneKitModelLoaderClient.mm
R Source/WebCore/Modules/model-element/scenekit/SceneKitModelLoaderUSD.h
R Source/WebCore/Modules/model-element/scenekit/SceneKitModelLoaderUSD.mm
R Source/WebCore/Modules/model-element/scenekit/SceneKitModelPlayer.h
R Source/WebCore/Modules/model-element/scenekit/SceneKitModelPlayer.mm
M Source/WebCore/Modules/speech/cocoa/WebSpeechRecognizerTask.mm
M Source/WebCore/Modules/speech/cocoa/WebSpeechRecognizerTaskMock.h
M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
M Source/WebCore/PAL/pal/PlatformMac.cmake
M Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h
R Source/WebCore/PAL/pal/spi/cocoa/SceneKitSPI.h
M Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h
R Source/WebCore/PAL/pal/spi/mac/SystemPreviewSPI.h
M Source/WebCore/PlatformMac.cmake
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/loader/LocalFrameLoaderClient.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/Configurations/AllowedSPI-legacy.toml
M Source/WebKit/Shared/Model.serialization.in
R Source/WebKit/Shared/ModelIdentifier.h
M Source/WebKit/Shared/WebProcessDataStoreParameters.h
M Source/WebKit/Shared/WebProcessDataStoreParameters.serialization.in
M Source/WebKit/Sources.txt
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm
R Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm
M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm
R Source/WebKit/UIProcess/ModelElementController.cpp
R Source/WebKit/UIProcess/ModelElementController.h
M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h
R Source/WebKit/UIProcess/ios/WKModelInteractionGestureRecognizer.h
R Source/WebKit/UIProcess/ios/WKModelInteractionGestureRecognizer.mm
R Source/WebKit/UIProcess/ios/WKModelView.h
R Source/WebKit/UIProcess/ios/WKModelView.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
R Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.h
R Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm
M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h
M Source/WebKit/WebProcess/Model/WebModelPlayerProvider.cpp
R Source/WebKit/WebProcess/Model/ios/ARKitInlinePreviewModelPlayerIOS.h
R Source/WebKit/WebProcess/Model/ios/ARKitInlinePreviewModelPlayerIOS.mm
R Source/WebKit/WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.h
R Source/WebKit/WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordForm.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFScriptEvaluation.mm
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.h
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.mm
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h
M Source/WebKit/WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.mm
M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.mm
M
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm
M Source/WebKit/WebProcess/WebProcess.cpp
M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
Log Message:
-----------
Remove the ARKit inline preview feature from WebKit
https://bugs.webkit.org/show_bug.cgi?id=311226
rdar://173490501
Reviewed by Etienne Segonzac.
Delete ARKitInline* and SceneKit* related files to avoid any
possible way of this code being compiled.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/PlatformEnable.h:
* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/Configurations/WebCore.xcconfig:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::inlinePreviewUUIDForTesting const): Deleted.
* Source/WebCore/Modules/model-element/HTMLModelElement.h:
* Source/WebCore/Modules/model-element/HTMLModelElement.idl:
* Source/WebCore/Modules/model-element/scenekit/SceneKitModel.h: Removed.
* Source/WebCore/Modules/model-element/scenekit/SceneKitModel.mm: Removed.
* Source/WebCore/Modules/model-element/scenekit/SceneKitModelLoader.h: Removed.
* Source/WebCore/Modules/model-element/scenekit/SceneKitModelLoader.mm: Removed.
* Source/WebCore/Modules/model-element/scenekit/SceneKitModelLoaderClient.h:
Removed.
* Source/WebCore/Modules/model-element/scenekit/SceneKitModelLoaderClient.mm:
Removed.
* Source/WebCore/Modules/model-element/scenekit/SceneKitModelLoaderUSD.h:
Removed.
* Source/WebCore/Modules/model-element/scenekit/SceneKitModelLoaderUSD.mm:
Removed.
* Source/WebCore/Modules/model-element/scenekit/SceneKitModelPlayer.h: Removed.
* Source/WebCore/Modules/model-element/scenekit/SceneKitModelPlayer.mm: Removed.
* Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:
* Source/WebCore/PAL/pal/PlatformMac.cmake:
* Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:
* Source/WebCore/PAL/pal/spi/cocoa/SceneKitSPI.h: Removed.
* Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h:
* Source/WebCore/PAL/pal/spi/mac/SystemPreviewSPI.h:
* Source/WebCore/PlatformMac.cmake:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/loader/LocalFrameLoaderClient.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::modelInlinePreviewUUIDs const): Deleted.
(WebCore::Internals::modelInlinePreviewUUIDForModelElement const): Deleted.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/Shared/Model.serialization.in:
* Source/WebKit/Shared/ModelIdentifier.h:
* Source/WebKit/Shared/WebProcessDataStoreParameters.h:
* Source/WebKit/Shared/WebProcessDataStoreParameters.serialization.in:
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:
(WebKit::ModelElementController::modelViewForModelIdentifier): Deleted.
(WebKit::ModelElementController::previewForModelIdentifier): Deleted.
(WebKit::ModelElementController::takeModelElementFullscreen): Deleted.
(WebKit::ModelElementController::setInteractionEnabledForModelElement): Deleted.
(WebKit::ModelElementController::modelElementCreateRemotePreview): Deleted.
(WebKit::ModelElementController::modelElementLoadRemotePreview): Deleted.
(WebKit::ModelElementController::modelElementDestroyRemotePreview): Deleted.
(WebKit::ModelElementController::previewForUUID): Deleted.
(WebKit::ModelElementController::handleMouseDownForModelElement): Deleted.
(WebKit::ModelElementController::handleMouseMoveForModelElement): Deleted.
(WebKit::ModelElementController::handleMouseUpForModelElement): Deleted.
(WebKit::ModelElementController::modelElementSizeDidChange): Deleted.
(WebKit::ModelElementController::inlinePreviewUUIDs): Deleted.
(WebKit::previewHasCameraSupport): Deleted.
(WebKit::ModelElementController::getCameraForModelElement): Deleted.
(WebKit::ModelElementController::setCameraForModelElement): Deleted.
(WebKit::previewHasAnimationSupport): Deleted.
(WebKit::ModelElementController::isPlayingAnimationForModelElement): Deleted.
(WebKit::ModelElementController::setAnimationIsPlayingForModelElement): Deleted.
(WebKit::ModelElementController::isLoopingAnimationForModelElement): Deleted.
(WebKit::ModelElementController::setIsLoopingAnimationForModelElement): Deleted.
(WebKit::ModelElementController::animationDurationForModelElement): Deleted.
(WebKit::ModelElementController::animationCurrentTimeForModelElement): Deleted.
(WebKit::ModelElementController::setAnimationCurrentTimeForModelElement):
Deleted.
(WebKit::previewHasAudioSupport): Deleted.
(WebKit::ModelElementController::hasAudioForModelElement): Deleted.
(WebKit::ModelElementController::isMutedForModelElement): Deleted.
(WebKit::ModelElementController::setIsMutedForModelElement): Deleted.
* Source/WebKit/UIProcess/ModelElementController.cpp:
(WebKit::ModelElementController::create): Deleted.
(WebKit::ModelElementController::ModelElementController): Deleted.
(WebKit::ModelElementController::page): Deleted.
* Source/WebKit/UIProcess/ModelElementController.h:
* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::makeNode):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didAttachToRunningProcess):
(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::modelElementGetCamera): Deleted.
(WebKit::WebPageProxy::modelElementSetCamera): Deleted.
(WebKit::WebPageProxy::modelElementIsPlayingAnimation): Deleted.
(WebKit::WebPageProxy::modelElementSetAnimationIsPlaying): Deleted.
(WebKit::WebPageProxy::modelElementIsLoopingAnimation): Deleted.
(WebKit::WebPageProxy::modelElementSetIsLoopingAnimation): Deleted.
(WebKit::WebPageProxy::modelElementAnimationDuration): Deleted.
(WebKit::WebPageProxy::modelElementAnimationCurrentTime): Deleted.
(WebKit::WebPageProxy::modelElementSetAnimationCurrentTime): Deleted.
(WebKit::WebPageProxy::modelElementHasAudio): Deleted.
(WebKit::WebPageProxy::modelElementIsMuted): Deleted.
(WebKit::WebPageProxy::modelElementSetIsMuted): Deleted.
(WebKit::WebPageProxy::takeModelElementFullscreen): Deleted.
(WebKit::WebPageProxy::modelElementSetInteractionEnabled): Deleted.
(WebKit::WebPageProxy::modelInlinePreviewDidLoad): Deleted.
(WebKit::WebPageProxy::modelInlinePreviewDidFailToLoad): Deleted.
(WebKit::WebPageProxy::modelElementCreateRemotePreview): Deleted.
(WebKit::WebPageProxy::modelElementLoadRemotePreview): Deleted.
(WebKit::WebPageProxy::modelElementDestroyRemotePreview): Deleted.
(WebKit::WebPageProxy::modelElementSizeDidChange): Deleted.
(WebKit::WebPageProxy::handleMouseDownForModelElement): Deleted.
(WebKit::WebPageProxy::handleMouseMoveForModelElement): Deleted.
(WebKit::WebPageProxy::handleMouseUpForModelElement): Deleted.
(WebKit::WebPageProxy::modelInlinePreviewUUIDs): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::webProcessDataStoreParameters):
* Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::defaultModelElementCacheDirectory): Deleted.
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::resolveDirectories):
(WebKit::WebsiteDataStore::handleResolvedDirectoriesAsynchronously):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
(WebKit::WebsiteDataStoreConfiguration::initializePaths):
(WebKit::WebsiteDataStoreConfiguration::Directories::isolatedCopy const):
(WebKit::WebsiteDataStoreConfiguration::Directories::isolatedCopy):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:
(WebKit::WebsiteDataStoreConfiguration::setModelElementCacheDirectory): Deleted.
* Source/WebKit/UIProcess/ios/WKModelInteractionGestureRecognizer.h:
* Source/WebKit/UIProcess/ios/WKModelInteractionGestureRecognizer.mm:
(-[WKModelInteractionGestureRecognizer touchesBegan:withEvent:]): Deleted.
(-[WKModelInteractionGestureRecognizer touchesMoved:withEvent:]): Deleted.
(-[WKModelInteractionGestureRecognizer touchesEnded:withEvent:]): Deleted.
(-[WKModelInteractionGestureRecognizer touchesCancelled:withEvent:]): Deleted.
* Source/WebKit/UIProcess/ios/WKModelView.h:
* Source/WebKit/UIProcess/ios/WKModelView.mm:
(-[WKModelView preview]): Deleted.
(-[WKModelView initWithFrame:]): Deleted.
(-[WKModelView initWithCoder:]): Deleted.
(-[WKModelView initWithModel:layerID:page:]): Deleted.
(-[WKModelView createFileForModel:]): Deleted.
(-[WKModelView createPreview]): Deleted.
(-[WKModelView layoutSubviews]): Deleted.
(-[WKModelView updateBounds]): Deleted.
(-[WKModelView hitTest:withEvent:]): Deleted.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.h: Removed.
* Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm: Removed.
* Source/WebKit/WebProcess/Model/WebModelPlayerProvider.cpp:
(WebKit::WebModelPlayerProvider::createModelPlayer):
* Source/WebKit/WebProcess/Model/ios/ARKitInlinePreviewModelPlayerIOS.h:
Removed.
* Source/WebKit/WebProcess/Model/ios/ARKitInlinePreviewModelPlayerIOS.mm:
Removed.
* Source/WebKit/WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.h:
Removed.
* Source/WebKit/WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.mm:
Removed.
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::modelInlinePreviewUUIDs const): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
(WebKit::WebPage::modelInlinePreviewDidLoad): Deleted.
(WebKit::WebPage::modelInlinePreviewDidFailToLoad): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setWebsiteDataStoreParameters):
(WebKit::WebProcess::didClose):
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::accessibilityFocusedUIElement):
Canonical link: https://commits.webkit.org/310669@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
