Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7cf5a940290e1c6460cdfece64d72271b6656f2
      
https://github.com/WebKit/WebKit/commit/c7cf5a940290e1c6460cdfece64d72271b6656f2
  Author: Adrian Perez de Castro <[email protected]>
  Date:   2026-04-07 (Tue, 07 Apr 2026)

  Changed paths:
    M Source/WebKit/PlatformWPE.cmake
    M Source/WebKit/SourcesWPE.txt
    M Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.h.in
    M Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabasePrivate.h
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in
    M Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h
    M Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.h.in
    M Source/WebKit/UIProcess/API/glib/webkit.h.in
    M Tools/TestWebKitAPI/Tests/WebKit/WKPage/glib/TestWebKitFaviconDatabase.cpp
    M Tools/TestWebKitAPI/glib/PlatformWPE.cmake

  Log Message:
  -----------
  [WPE] Favicon database support
https://bugs.webkit.org/show_bug.cgi?id=296927

Reviewed by Carlos Garcia Campos.

Adjust preprocessor guards to include only the parts that implement the
new "page icons API" when building the WPE port: the "page-icons" web
view property and getter, and the favicon database methods to obtain the
list of icons for a given URI.

The rest of code which implements the old "favicons API" is guarded to
be built only for the GTK port.

The TestWebKitFaviconDatabase test suite is rearranged to make the
"get-page-icons" test case build and run. The changes needed for this
already give a hint of how unwieldy it would have been to enable the
rest of the test cases, so that is left to be done later.

* Source/WebKit/PlatformWPE.cmake: Add needed files to the build.
* Source/WebKit/SourcesWPE.txt: Ditto.
* Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp:
(webkit_favicon_database_class_init):
(webkitFaviconDatabaseGetLoadDecisionForIcon):
(webkitFaviconDatabaseSetIconForPageURL):
(webkit_favicon_database_get_favicon_uri):
* Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.h.in:
* Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabasePrivate.h:
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewGetFaviconDatabase):
(webkitWebViewConstructed):
(webkitWebViewGetProperty):
(webkit_web_view_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in:
* Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h:
* Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.h.in:
* Source/WebKit/UIProcess/API/glib/webkit.h.in:
* Tools/TestWebKitAPI/Tests/WebKit/WKPage/glib/TestWebKitFaviconDatabase.cpp:
(testFaviconDatabaseGetPageIcons):
(beforeAll):
* Tools/TestWebKitAPI/glib/PlatformWPE.cmake:

Canonical link: https://commits.webkit.org/310697@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to