Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3b5e0fe59a00303f28bdaaa7c8f222b2aac5ee84
https://github.com/WebKit/WebKit/commit/3b5e0fe59a00303f28bdaaa7c8f222b2aac5ee84
Author: Sammy Gill <[email protected]>
Date: 2026-04-09 (Thu, 09 Apr 2026)
Changed paths:
M Source/WebCore/layout/integration/grid/LayoutIntegrationGridCoverage.cpp
Log Message:
-----------
[GFC][Cleanup] Change ADD_REASON_AND_RETURN_IF_NEEDED to accept
GridAvoidanceReason values directly
https://bugs.webkit.org/show_bug.cgi?id=311853
rdar://174438472
Reviewed by Vitor Roriz.
Right now we just pass in the value of the enum into this marco without
the scope of the class (i.e. GridItemHasUnsupportedColumnPlacement
instead of GridAvoidanceReason::GridItemHasUnsupportedColumnPlacement).
This prevents us from passing in a lvalue that we have in the code. In
this patch we make this possible by changing the macro and modifying the
call sites as needed. There are two cases (column and row placement)
where we have a GridAvoidanceReason stored in a local variable so in
those call sites I also start passing those in directly. In a follow up
I plan to make these reasons more fine grained compared to what they are
now so this will allow us to do so without changing these sites in that
additional patch.
Canonical link: https://commits.webkit.org/310896@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
