Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 125597185d4fd58193e9cf35ec5e1a5c6417143b
https://github.com/WebKit/WebKit/commit/125597185d4fd58193e9cf35ec5e1a5c6417143b
Author: Sam Weinig <[email protected]>
Date: 2026-04-10 (Fri, 10 Apr 2026)
Changed paths:
M Source/WebCore/CMakeLists.txt
M Source/WebCore/Headers.cmake
M Source/WebCore/SaferCPPExpectations/NoDeleteCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/animation/CSSAnimation.cpp
M Source/WebCore/animation/StyleOriginatedTimelinesController.cpp
M Source/WebCore/animation/StyleOriginatedTimelinesController.h
R Source/WebCore/css/CSSCounterStyle.cpp
R Source/WebCore/css/CSSCounterStyle.h
M Source/WebCore/css/CSSCounterStyleDescriptors.cpp
M Source/WebCore/css/CSSCounterStyleRegistry.cpp
M Source/WebCore/css/CSSCounterStyleRegistry.h
M Source/WebCore/css/CSSCounterStyleRule.h
M Source/WebCore/css/CSSCounterValue.cpp
M Source/WebCore/css/CSSCounterValue.h
A Source/WebCore/css/CSSCustomIdentValue.cpp
A Source/WebCore/css/CSSCustomIdentValue.h
M Source/WebCore/css/CSSGridLineNamesValue.cpp
M Source/WebCore/css/CSSGridLineNamesValue.h
M Source/WebCore/css/CSSGridLineValue.cpp
M Source/WebCore/css/CSSGridLineValue.h
M Source/WebCore/css/CSSPrimitiveValue.cpp
M Source/WebCore/css/CSSPrimitiveValue.h
A Source/WebCore/css/CSSRegisteredCounterStyle.cpp
A Source/WebCore/css/CSSRegisteredCounterStyle.h
M Source/WebCore/css/CSSUnits.cpp
M Source/WebCore/css/CSSUnits.h
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/CSSValue.h
M Source/WebCore/css/CSSViewTransitionRule.cpp
M Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.cpp
M Source/WebCore/css/ShorthandSerializer.cpp
M Source/WebCore/css/calc/CSSCalcRandomCachingKey.h
M Source/WebCore/css/calc/CSSCalcTree+Evaluation.cpp
M Source/WebCore/css/calc/CSSCalcTree+NumericIdentity.h
M Source/WebCore/css/calc/CSSCalcTree+Parser.cpp
M Source/WebCore/css/calc/CSSCalcTree+Serialization.cpp
M Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp
M Source/WebCore/css/calc/CSSCalcTree+Traversal.h
M Source/WebCore/css/calc/CSSCalcTree.cpp
M Source/WebCore/css/calc/CSSCalcTree.h
M Source/WebCore/css/calc/CSSCalcType.cpp
M Source/WebCore/css/parser/CSSCustomPropertySyntax.cpp
M Source/WebCore/css/parser/CSSCustomPropertySyntax.h
M Source/WebCore/css/parser/CSSParser.cpp
M Source/WebCore/css/parser/CSSPropertyParser.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Animations.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+ColorAdjust.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Content.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Grid.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Grid.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Ident.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Ident.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Lists.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+PositionTry.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Transitions.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+ViewTransition.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+WillChange.cpp
M Source/WebCore/css/parser/CSSPropertyParserCustom.h
M Source/WebCore/css/parser/CSSSelectorParser.cpp
M Source/WebCore/css/query/ContainerQueryParser.cpp
M Source/WebCore/css/scripts/process-css-properties.py
M Source/WebCore/css/typedom/CSSKeywordValue.cpp
M Source/WebCore/css/typedom/CSSStyleValueFactory.cpp
M Source/WebCore/css/values/CSSValueAggregates.cpp
M Source/WebCore/css/values/CSSValueAggregates.h
M Source/WebCore/css/values/CSSValueTypes.cpp
M Source/WebCore/css/values/CSSValueTypes.h
M Source/WebCore/css/values/color-adjust/CSSColorScheme.h
A Source/WebCore/css/values/counter-styles/CSSCounterStyle.h
M Source/WebCore/css/values/grid/CSSGridNamedAreaMap.h
A Source/WebCore/css/values/primitives/CSSCustomIdent.cpp
A Source/WebCore/css/values/primitives/CSSCustomIdent.h
M Source/WebCore/css/values/primitives/CSSPrimitiveNumeric.h
M Source/WebCore/css/values/primitives/CSSPrimitiveNumericRange.h
M Source/WebCore/dom/ViewTransition.cpp
M Source/WebCore/inspector/InspectorOverlay.cpp
M Source/WebCore/layout/formattingContexts/grid/GridFormattingContext.cpp
M Source/WebCore/layout/integration/grid/LayoutIntegrationGridCoverage.cpp
M Source/WebCore/rendering/RenderCounter.cpp
M Source/WebCore/rendering/RenderCounter.h
M Source/WebCore/rendering/RenderListMarker.cpp
M Source/WebCore/rendering/RenderListMarker.h
M Source/WebCore/style/AnchorPositionEvaluator.cpp
M Source/WebCore/style/ScopedName.cpp
M Source/WebCore/style/ScopedName.h
M Source/WebCore/style/StyleBuilderChecking.h
M Source/WebCore/style/StyleCustomProperty.h
M Source/WebCore/style/StyleExtractorCustom.h
M Source/WebCore/style/StyleInterpolation.cpp
M Source/WebCore/style/StyleNameScope.cpp
M Source/WebCore/style/StyleNameScope.h
M Source/WebCore/style/StyleOrderedNamedLinesCollector.h
M Source/WebCore/style/Styleable.cpp
M Source/WebCore/style/calc/StyleCalculationTree+Conversion.cpp
M Source/WebCore/style/values/StyleValueTypes+CSSValueConversion.h
M Source/WebCore/style/values/StyleValueTypes.h
M Source/WebCore/style/values/anchor-position/StylePositionTryFallback.cpp
M Source/WebCore/style/values/animations/StyleSingleAnimationName.cpp
M Source/WebCore/style/values/animations/StyleSingleAnimationTimeline.cpp
M Source/WebCore/style/values/animations/StyleSingleAnimationTimeline.h
M Source/WebCore/style/values/color-adjust/StyleColorScheme.h
M Source/WebCore/style/values/content/StyleContent.cpp
M Source/WebCore/style/values/content/StyleContent.h
M Source/WebCore/style/values/counter-styles/StyleCounterStyle.cpp
M Source/WebCore/style/values/counter-styles/StyleCounterStyle.h
M Source/WebCore/style/values/fonts/StyleFontPalette.cpp
M Source/WebCore/style/values/fonts/StyleFontPalette.h
M Source/WebCore/style/values/fonts/StyleFontVariantAlternates.cpp
M Source/WebCore/style/values/grid/StyleGridNamedLinesMap.h
M Source/WebCore/style/values/grid/StyleGridOrderedNamedLinesMap.h
M Source/WebCore/style/values/grid/StyleGridPosition.cpp
M Source/WebCore/style/values/grid/StyleGridPosition.h
M Source/WebCore/style/values/grid/StyleGridPositionsResolver.cpp
M Source/WebCore/style/values/grid/StyleGridTemplateAreas.cpp
M Source/WebCore/style/values/grid/StyleGridTemplateList.cpp
M Source/WebCore/style/values/grid/StyleGridTemplateList.h
M Source/WebCore/style/values/line-grid/StyleWebKitLineGrid.h
M Source/WebCore/style/values/lists/StyleCounterIncrement.cpp
M Source/WebCore/style/values/lists/StyleCounterIncrement.h
M Source/WebCore/style/values/lists/StyleCounterReset.cpp
M Source/WebCore/style/values/lists/StyleCounterReset.h
M Source/WebCore/style/values/lists/StyleCounterSet.cpp
M Source/WebCore/style/values/lists/StyleCounterSet.h
M Source/WebCore/style/values/lists/StyleListStyleType.cpp
M Source/WebCore/style/values/non-standard/StyleWebKitLocale.h
A Source/WebCore/style/values/primitives/StyleCustomIdent.cpp
A Source/WebCore/style/values/primitives/StyleCustomIdent.h
M
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Conversions.h
M Source/WebCore/style/values/scroll-animations/StyleProgressTimelineName.h
M Source/WebCore/style/values/transitions/StyleSingleTransitionProperty.cpp
M Source/WebCore/style/values/transitions/StyleSingleTransitionProperty.h
M Source/WebCore/style/values/view-transitions/StyleViewTransitionName.cpp
M Source/WebCore/style/values/view-transitions/StyleViewTransitionName.h
Log Message:
-----------
Split WebCore::CustomIdentifier into separate
CSS::CustomIdent/Style::CustomIdent types
https://bugs.webkit.org/show_bug.cgi?id=311269
Reviewed by Darin Adler.
This extends a PR from @sakupi01 (https://github.com/WebKit/WebKit/pull/59674),
adding
and adopting new CSS::CustomIdent/Style::CustomIdent types in preparation for
adding
support for the CSS ident() function.
In addition to the CSS::CustomIdent/Style::CustomIdent types, a number of
additional
types were also needed.
- CSSCustomIdentValue was added, replacing usage of CSSPrimitiveValue for
custom idents.
- CSSCounterStyle was renamed to CSSRegisteredCounterStyle, freeing up
CSSCounterStyle.h
for CSS::CounterStyle.
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/CSSAnimation.cpp:
* Source/WebCore/animation/StyleOriginatedTimelinesController.cpp:
* Source/WebCore/animation/StyleOriginatedTimelinesController.h:
* Source/WebCore/css/CSSCounterStyleDescriptors.cpp:
* Source/WebCore/css/CSSCounterStyleRegistry.cpp:
* Source/WebCore/css/CSSCounterStyleRegistry.h:
* Source/WebCore/css/CSSCounterStyleRule.h:
* Source/WebCore/css/CSSCounterValue.cpp:
* Source/WebCore/css/CSSCounterValue.h:
* Source/WebCore/css/CSSCustomIdentValue.cpp: Added.
* Source/WebCore/css/CSSCustomIdentValue.h: Added.
* Source/WebCore/css/CSSGridLineNamesValue.cpp:
* Source/WebCore/css/CSSGridLineNamesValue.h:
* Source/WebCore/css/CSSGridLineValue.cpp:
* Source/WebCore/css/CSSGridLineValue.h:
* Source/WebCore/css/CSSPrimitiveValue.cpp:
* Source/WebCore/css/CSSPrimitiveValue.h:
* Source/WebCore/css/CSSRegisteredCounterStyle.cpp: Renamed from
Source/WebCore/css/CSSCounterStyle.cpp.
* Source/WebCore/css/CSSRegisteredCounterStyle.h: Renamed from
Source/WebCore/css/CSSCounterStyle.h.
* Source/WebCore/css/CSSUnits.cpp:
* Source/WebCore/css/CSSUnits.h:
* Source/WebCore/css/CSSValue.cpp:
* Source/WebCore/css/CSSValue.h:
* Source/WebCore/css/CSSViewTransitionRule.cpp:
* Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.cpp:
* Source/WebCore/css/ShorthandSerializer.cpp:
* Source/WebCore/css/calc/CSSCalcRandomCachingKey.h:
* Source/WebCore/css/calc/CSSCalcTree+Evaluation.cpp:
* Source/WebCore/css/calc/CSSCalcTree+NumericIdentity.h:
* Source/WebCore/css/calc/CSSCalcTree+Parser.cpp:
* Source/WebCore/css/calc/CSSCalcTree+Serialization.cpp:
* Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp:
* Source/WebCore/css/calc/CSSCalcTree.cpp:
* Source/WebCore/css/calc/CSSCalcTree.h:
* Source/WebCore/css/calc/CSSCalcType.cpp:
* Source/WebCore/css/parser/CSSCustomPropertySyntax.cpp:
* Source/WebCore/css/parser/CSSCustomPropertySyntax.h:
* Source/WebCore/css/parser/CSSParser.cpp:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Animations.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+ColorAdjust.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Content.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Grid.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Grid.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Ident.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Ident.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Lists.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+PositionTry.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Transitions.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+ViewTransition.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+WillChange.cpp:
* Source/WebCore/css/parser/CSSPropertyParserCustom.h:
* Source/WebCore/css/parser/CSSSelectorParser.cpp:
* Source/WebCore/css/query/ContainerQueryParser.cpp:
* Source/WebCore/css/scripts/process-css-properties.py:
* Source/WebCore/css/typedom/CSSKeywordValue.cpp:
* Source/WebCore/css/values/CSSValueAggregates.cpp:
* Source/WebCore/css/values/CSSValueAggregates.h:
* Source/WebCore/css/values/CSSValueTypes.cpp:
* Source/WebCore/css/values/CSSValueTypes.h:
* Source/WebCore/css/values/color-adjust/CSSColorScheme.h:
* Source/WebCore/css/values/counter-styles/CSSCounterStyle.h: Added.
* Source/WebCore/css/values/grid/CSSGridNamedAreaMap.h:
* Source/WebCore/css/values/primitives/CSSCustomIdent.cpp: Added.
* Source/WebCore/css/values/primitives/CSSCustomIdent.h: Added.
* Source/WebCore/css/values/primitives/CSSPrimitiveNumeric.h:
* Source/WebCore/css/values/primitives/CSSPrimitiveNumericRange.h:
* Source/WebCore/dom/ViewTransition.cpp:
* Source/WebCore/inspector/InspectorOverlay.cpp:
* Source/WebCore/layout/formattingContexts/grid/GridFormattingContext.cpp:
* Source/WebCore/layout/integration/grid/LayoutIntegrationGridCoverage.cpp:
* Source/WebCore/rendering/RenderCounter.cpp:
* Source/WebCore/rendering/RenderCounter.h:
* Source/WebCore/rendering/RenderListMarker.cpp:
* Source/WebCore/rendering/RenderListMarker.h:
* Source/WebCore/style/AnchorPositionEvaluator.cpp:
* Source/WebCore/style/ScopedName.cpp:
* Source/WebCore/style/ScopedName.h:
* Source/WebCore/style/StyleBuilderChecking.h:
* Source/WebCore/style/StyleCustomProperty.h:
* Source/WebCore/style/StyleExtractorCustom.h:
* Source/WebCore/style/StyleInterpolation.cpp:
* Source/WebCore/style/StyleNameScope.cpp:
* Source/WebCore/style/StyleNameScope.h:
* Source/WebCore/style/StyleOrderedNamedLinesCollector.h:
* Source/WebCore/style/Styleable.cpp:
* Source/WebCore/style/calc/StyleCalculationTree+Conversion.cpp:
* Source/WebCore/style/values/StyleValueTypes+CSSValueConversion.h:
* Source/WebCore/style/values/StyleValueTypes.h:
* Source/WebCore/style/values/anchor-position/StylePositionTryFallback.cpp:
* Source/WebCore/style/values/animations/StyleSingleAnimationName.cpp:
* Source/WebCore/style/values/animations/StyleSingleAnimationTimeline.cpp:
* Source/WebCore/style/values/animations/StyleSingleAnimationTimeline.h:
* Source/WebCore/style/values/color-adjust/StyleColorScheme.h:
* Source/WebCore/style/values/content/StyleContent.cpp:
* Source/WebCore/style/values/content/StyleContent.h:
* Source/WebCore/style/values/counter-styles/StyleCounterStyle.h:
* Source/WebCore/style/values/fonts/StyleFontPalette.cpp:
* Source/WebCore/style/values/fonts/StyleFontPalette.h:
* Source/WebCore/style/values/fonts/StyleFontVariantAlternates.cpp:
* Source/WebCore/style/values/grid/StyleGridNamedLinesMap.h:
* Source/WebCore/style/values/grid/StyleGridOrderedNamedLinesMap.h:
* Source/WebCore/style/values/grid/StyleGridPosition.cpp:
* Source/WebCore/style/values/grid/StyleGridPosition.h:
* Source/WebCore/style/values/grid/StyleGridPositionsResolver.cpp:
* Source/WebCore/style/values/grid/StyleGridTemplateAreas.cpp:
* Source/WebCore/style/values/grid/StyleGridTemplateList.cpp:
* Source/WebCore/style/values/grid/StyleGridTemplateList.h:
* Source/WebCore/style/values/line-grid/StyleWebKitLineGrid.h:
* Source/WebCore/style/values/lists/StyleCounterIncrement.cpp:
* Source/WebCore/style/values/lists/StyleCounterIncrement.h:
* Source/WebCore/style/values/lists/StyleCounterReset.cpp:
* Source/WebCore/style/values/lists/StyleCounterReset.h:
* Source/WebCore/style/values/lists/StyleCounterSet.cpp:
* Source/WebCore/style/values/lists/StyleCounterSet.h:
* Source/WebCore/style/values/lists/StyleListStyleType.cpp:
* Source/WebCore/style/values/non-standard/StyleWebKitLocale.h:
* Source/WebCore/style/values/primitives/StyleCustomIdent.cpp: Added.
* Source/WebCore/style/values/primitives/StyleCustomIdent.h: Added.
* Source/WebCore/style/values/scroll-animations/StyleProgressTimelineName.h:
* Source/WebCore/style/values/transitions/StyleSingleTransitionProperty.cpp:
* Source/WebCore/style/values/transitions/StyleSingleTransitionProperty.h:
* Source/WebCore/style/values/view-transitions/StyleViewTransitionName.cpp:
* Source/WebCore/style/values/view-transitions/StyleViewTransitionName.h:
Canonical link: https://commits.webkit.org/310915@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
