Title: [114654] trunk/Source/WebCore
- Revision
- 114654
- Author
- [email protected]
- Date
- 2012-04-19 11:18:01 -0700 (Thu, 19 Apr 2012)
Log Message
Web Inspector: exception when hovering object while paused
https://bugs.webkit.org/show_bug.cgi?id=84358
Added missing boolean parameter to the call site of evaluate method
on call frame.
Reviewed by Vsevolod Vlasov.
* inspector/front-end/AdvancedSearchController.js:
* inspector/front-end/DebuggerPresentationModel.js: annotated slectedCallFrame
method so that closure compiler catches errors like in the bug report.
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame.prototype._resolveObjectForPopover):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (114653 => 114654)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 18:17:58 UTC (rev 114653)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 18:18:01 UTC (rev 114654)
@@ -1,5 +1,22 @@
2012-04-19 Yury Semikhatsky <[email protected]>
+ Web Inspector: exception when hovering object while paused
+ https://bugs.webkit.org/show_bug.cgi?id=84358
+
+ Added missing boolean parameter to the call site of evaluate method
+ on call frame.
+
+ Reviewed by Vsevolod Vlasov.
+
+ * inspector/front-end/AdvancedSearchController.js:
+ * inspector/front-end/DebuggerPresentationModel.js: annotated slectedCallFrame
+ method so that closure compiler catches errors like in the bug report.
+ (WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
+ * inspector/front-end/_javascript_SourceFrame.js:
+ (WebInspector._javascript_SourceFrame.prototype._resolveObjectForPopover):
+
+2012-04-19 Yury Semikhatsky <[email protected]>
+
Web Inspector: nodes are not removed from the summary view when switching between allocation ranges
https://bugs.webkit.org/show_bug.cgi?id=84354
Modified: trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js (114653 => 114654)
--- trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js 2012-04-19 18:17:58 UTC (rev 114653)
+++ trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js 2012-04-19 18:18:01 UTC (rev 114654)
@@ -450,7 +450,7 @@
/**
* @param {WebInspector.SearchConfig} searchConfig
- * @return WebInspector.SearchResultsPane}
+ * @return {WebInspector.SearchResultsPane}
*/
createSearchResultsPane: function(searchConfig) { }
}
Modified: trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (114653 => 114654)
--- trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-04-19 18:17:58 UTC (rev 114653)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2012-04-19 18:18:01 UTC (rev 114654)
@@ -453,6 +453,9 @@
this._executionLineLiveLocation.init();
},
+ /**
+ * @return {?WebInspector.PresentationCallFrame}
+ */
get selectedCallFrame()
{
return this._selectedCallFrame;
@@ -470,14 +473,14 @@
{
/**
* @param {?RuntimeAgent.RemoteObject} result
- * @param {boolean} wasThrown
+ * @param {boolean=} wasThrown
*/
function didEvaluate(result, wasThrown)
{
if (returnByValue)
- callback(null, wasThrown, wasThrown ? null : result);
+ callback(null, !!wasThrown, wasThrown ? null : result);
else
- callback(WebInspector.RemoteObject.fromPayload(result), wasThrown);
+ callback(WebInspector.RemoteObject.fromPayload(result), !!wasThrown);
if (objectGroup === "console")
this.dispatchEventToListeners(WebInspector.DebuggerPresentationModel.Events.ConsoleCommandEvaluatedInSelectedCallFrame);
Modified: trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js (114653 => 114654)
--- trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js 2012-04-19 18:17:58 UTC (rev 114653)
+++ trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js 2012-04-19 18:18:01 UTC (rev 114654)
@@ -263,6 +263,10 @@
{
this._highlightElement = this._highlightExpression(element);
+ /**
+ * @param {?RuntimeAgent.RemoteObject} result
+ * @param {boolean=} wasThrown
+ */
function showObjectPopover(result, wasThrown)
{
if (!this._model.paused) {
@@ -276,7 +280,7 @@
}
var selectedCallFrame = this._model.selectedCallFrame;
- selectedCallFrame.evaluate(this._highlightElement.textContent, objectGroupName, false, false, showObjectPopover.bind(this));
+ selectedCallFrame.evaluate(this._highlightElement.textContent, objectGroupName, false, true, false, showObjectPopover.bind(this));
},
_onHidePopover: function()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
