Title: [114665] trunk/Source/WebKit2
- Revision
- 114665
- Author
- [email protected]
- Date
- 2012-04-19 12:12:42 -0700 (Thu, 19 Apr 2012)
Log Message
DevTools: assertion failure upon devtools window reopen.
https://bugs.webkit.org/show_bug.cgi?id=53493
Patch by Vivek Galatage <[email protected]> on 2012-04-19
Reviewed by Pavel Feldman.
The pointers pointed to by WebInspector must be reset explicitly
in WebInspector::didClose() method
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::closeInspectorFrontend):
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::didClose):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (114664 => 114665)
--- trunk/Source/WebKit2/ChangeLog 2012-04-19 19:08:58 UTC (rev 114664)
+++ trunk/Source/WebKit2/ChangeLog 2012-04-19 19:12:42 UTC (rev 114665)
@@ -1,3 +1,18 @@
+2012-04-19 Vivek Galatage <[email protected]>
+
+ DevTools: assertion failure upon devtools window reopen.
+ https://bugs.webkit.org/show_bug.cgi?id=53493
+
+ Reviewed by Pavel Feldman.
+
+ The pointers pointed to by WebInspector must be reset explicitly
+ in WebInspector::didClose() method
+
+ * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
+ (WebKit::WebInspectorClient::closeInspectorFrontend):
+ * WebProcess/WebPage/WebInspector.cpp:
+ (WebKit::WebInspector::didClose):
+
2012-04-19 Zalan Bujtas <[email protected]>
[Qt][WK2] Zoom out on the second double click does not always scale right.
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp (114664 => 114665)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp 2012-04-19 19:08:58 UTC (rev 114664)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp 2012-04-19 19:12:42 UTC (rev 114665)
@@ -53,7 +53,6 @@
{
if (m_page->inspector()) {
m_page->inspector()->didClose();
- m_page->inspector()->destroyInspectorPage();
}
}
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp (114664 => 114665)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp 2012-04-19 19:08:58 UTC (rev 114664)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp 2012-04-19 19:12:42 UTC (rev 114665)
@@ -102,6 +102,7 @@
void WebInspector::didClose()
{
WebProcess::shared().connection()->send(Messages::WebInspectorProxy::DidClose(), m_page->pageID());
+ destroyInspectorPage();
}
void WebInspector::bringToFront()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
