Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 68c43f3fd9ecc6e734d0155a170c68b1649b0d67
https://github.com/WebKit/WebKit/commit/68c43f3fd9ecc6e734d0155a170c68b1649b0d67
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-04-20 (Mon, 20 Apr 2026)
Changed paths:
M Tools/Scripts/webkitdirs.pm
Log Message:
-----------
[WPE][cross-toolchain-helper] determineArchitecture() in webkitdirs.pm
doesn't handle correctly the cross-toolchain-helper case.
https://bugs.webkit.org/show_bug.cgi?id=311694
Reviewed by Philippe Normand.
When using cross-toolchain-helper determineArchitecture() in webkitdirs.pm fails
to correctly determine the target architecture.
The problem is that determineArchitecture() gets called before entering into the
cross-target environment because the value of architecuture is needed to resolve
the values of argumentsForConfiguration() which are passed when the build-webkit
gets re-execed into the cross-target environment.
So at that moment it can't reliable obtain the target architecture, and instead
it obtains the host one because the CC environment variable with the
cross-compiler
is still not set.
To fix this problem this patch detects this edge case and then calls the cmake
binary from the cross-toolchain SDK which is configured to resolve the target
architecture.
* Tools/Scripts/webkitdirs.pm:
(determineArchitecture):
Canonical link: https://commits.webkit.org/311591@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
