Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b961212f23f526f686ed95b8bfbc943e8cf77f5
      
https://github.com/WebKit/WebKit/commit/3b961212f23f526f686ed95b8bfbc943e8cf77f5
  Author: Geoffrey Garen <[email protected]>
  Date:   2026-04-20 (Mon, 20 Apr 2026)

  Changed paths:
    M Tools/Scripts/webkitpy/style/checker.py
    M Tools/Scripts/webkitpy/style/checker_unittest.py
    M Tools/Scripts/webkitpy/style/checkers/basexcconfig.py
    M Tools/Scripts/webkitpy/style/checkers/changelog.py
    M Tools/Scripts/webkitpy/style/checkers/cmake.py
    M Tools/Scripts/webkitpy/style/checkers/common.py
    M Tools/Scripts/webkitpy/style/checkers/contributors.py
    M Tools/Scripts/webkitpy/style/checkers/cpp.py
    M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
    M Tools/Scripts/webkitpy/style/checkers/inclusive_language.py
    M Tools/Scripts/webkitpy/style/checkers/js.py
    M Tools/Scripts/webkitpy/style/checkers/jsonchecker.py
    M Tools/Scripts/webkitpy/style/checkers/jstest.py
    M Tools/Scripts/webkitpy/style/checkers/messagesin.py
    M Tools/Scripts/webkitpy/style/checkers/python.py
    M Tools/Scripts/webkitpy/style/checkers/spi_allowlist.py
    M Tools/Scripts/webkitpy/style/checkers/swift.py
    M Tools/Scripts/webkitpy/style/checkers/test_expectations.py
    M Tools/Scripts/webkitpy/style/checkers/text.py
    M Tools/Scripts/webkitpy/style/checkers/watchlist.py
    M Tools/Scripts/webkitpy/style/checkers/xcodeproj.py
    M Tools/Scripts/webkitpy/style/checkers/xcscheme.py
    M Tools/Scripts/webkitpy/style/checkers/xml.py

  Log Message:
  -----------
  Speed up check-webkit-style (and git webkit pr)
https://bugs.webkit.org/show_bug.cgi?id=312739
rdar://175135229

Reviewed by David Kilzer.

4.1X speedup (75.8s => 18.4s for a large patch).

check-webkit-style runs on every git webkit pr, so it's important for it to be
fast.

Pass through line_numbers and short-circuit single-line checkers when the line
in question wasn't modified by the current patch.

Pre-flight check_os_version_checks with a simple substring check because the
regular expression is written in O(N^2) backtracking style.

Canonical link: https://commits.webkit.org/311595@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to