Title: [114676] trunk/Source/WebCore
- Revision
- 114676
- Author
- [email protected]
- Date
- 2012-04-19 14:56:59 -0700 (Thu, 19 Apr 2012)
Log Message
Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to current()).
https://bugs.webkit.org/show_bug.cgi?id=84369
Reviewed by Simon Fraser.
No new tests / code cleanup only.
* css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::MediaQueryExp):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (114675 => 114676)
--- trunk/Source/WebCore/ChangeLog 2012-04-19 21:55:00 UTC (rev 114675)
+++ trunk/Source/WebCore/ChangeLog 2012-04-19 21:56:59 UTC (rev 114676)
@@ -1,3 +1,15 @@
+2012-04-19 Luke Macpherson <[email protected]>
+
+ Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to current()).
+ https://bugs.webkit.org/show_bug.cgi?id=84369
+
+ Reviewed by Simon Fraser.
+
+ No new tests / code cleanup only.
+
+ * css/MediaQueryExp.cpp:
+ (WebCore::MediaQueryExp::MediaQueryExp):
+
2012-04-19 Mark Pilgrim <[email protected]>
[Chromium] Call signedPublicKeyAndChallengeString directly
Modified: trunk/Source/WebCore/css/MediaQueryExp.cpp (114675 => 114676)
--- trunk/Source/WebCore/css/MediaQueryExp.cpp 2012-04-19 21:55:00 UTC (rev 114675)
+++ trunk/Source/WebCore/css/MediaQueryExp.cpp 2012-04-19 21:56:59 UTC (rev 114676)
@@ -59,10 +59,10 @@
// currently accepts only <integer>/<integer>
RefPtr<CSSValueList> list = CSSValueList::createCommaSeparated();
- CSSParserValue* value = 0;
+ CSSParserValue* value = valueList->current();
bool isValid = true;
- while ((value = valueList->current()) && isValid) {
+ while (value && isValid) {
if (value->unit == CSSParserValue::Operator && value->iValue == '/')
list->append(CSSPrimitiveValue::create("/", CSSPrimitiveValue::CSS_STRING));
else if (value->unit == CSSPrimitiveValue::CSS_NUMBER)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
