Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 75841772426172ad143ea178fd92d3cf49bd2f00
https://github.com/WebKit/WebKit/commit/75841772426172ad143ea178fd92d3cf49bd2f00
Author: Dominic Mazzoni <[email protected]>
Date: 2026-04-20 (Mon, 20 Apr 2026)
Changed paths:
A
LayoutTests/accessibility/aria-hidden-focus-not-overridden-when-caught-expected.txt
A
LayoutTests/accessibility/aria-hidden-focus-not-overridden-when-caught.html
A LayoutTests/accessibility/aria-hidden-focus-override-expected.txt
A LayoutTests/accessibility/aria-hidden-focus-override.html
M LayoutTests/accessibility/focusable-inside-hidden-expected.txt
M LayoutTests/accessibility/focusable-inside-hidden.html
M
LayoutTests/platform/glib/accessibility/focusable-inside-hidden-expected.txt
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/page/Page.cpp
Log Message:
-----------
AX: align with other browsers on handling of focused elements and aria-hidden
https://bugs.webkit.org/show_bug.cgi?id=311881
rdar://174449524
Reviewed by Tyler Wilcock.
Discussed here:
https://github.com/w3c/aria/pull/2181#discussion_r2002079011
The consensus seems to be that if focus lands inside an aria-hidden
region, and an event handler doesn't move focus elsewhere before one
animation frame, then the aria-hidden flag should be ignored and that
region should be essentially permanently un-hidden.
This is essentially a workaround for an authoring error.
Previously, WebKit's behavior was to ignore aria-hidden when focus was
inside but not persist that change.
Tests: accessibility/aria-hidden-focus-not-overridden-when-caught.html
accessibility/aria-hidden-focus-override.html
*
LayoutTests/accessibility/aria-hidden-focus-not-overridden-when-caught-expected.txt:
Added.
* LayoutTests/accessibility/aria-hidden-focus-not-overridden-when-caught.html:
Added.
* LayoutTests/accessibility/aria-hidden-focus-override-expected.txt: Added.
* LayoutTests/accessibility/aria-hidden-focus-override.html: Added.
* LayoutTests/accessibility/focusable-inside-hidden-expected.txt:
* LayoutTests/accessibility/focusable-inside-hidden.html:
* LayoutTests/platform/glib/accessibility/focusable-inside-hidden-expected.txt:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::onPostRenderingUpdate):
(WebCore::AXObjectCache::handleAriaHiddenChange):
(WebCore::AXObjectCache::handleAttributeChange):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isARIAHidden const):
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::shouldIgnoreARIAHidden const):
(WebCore::AccessibilityObject::setShouldIgnoreARIAHidden):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::doAfterUpdateRendering):
Canonical link: https://commits.webkit.org/311648@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
