Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 25e87df15e5142655bfdceb1272083858dbd2d81
https://github.com/WebKit/WebKit/commit/25e87df15e5142655bfdceb1272083858dbd2d81
Author: Tim Horton <[email protected]>
Date: 2026-04-20 (Mon, 20 Apr 2026)
Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/commit.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/commit_unittest.py
Log Message:
-----------
Generated commit messages should always sort Bugzilla link before alternate
bug trackers
https://bugs.webkit.org/show_bug.cgi?id=312633
rdar://175062395
Reviewed by Richard Robinson and Abrar Rahman Protyasha.
Currently, depending on the order in which bug references are learned about,
we will generate a commit message with any bug tracker's link as the "primary".
For example, if you use `git webkit pr` and give it a rdar:// link to start
with,
that becomes the primary reference, and the tool promptly turns around and
generates
a commit header:
TITLE
RADAR LINK
BUGZILLA LINK
But this really isn't how the WebKit project works. The Bugzilla reference
should
always come first. Bugzilla is the primary bug tracker. The rest are all
secondary.
To fix this, sort the references before generating the header, always
preferring Bugzilla.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/commit.py:
(Commit.bug_urls):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/commit_unittest.py:
Canonical link: https://commits.webkit.org/311651@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
