Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9b4359d195c9f8f4a9415644ba3e334d316fe6b2
https://github.com/WebKit/WebKit/commit/9b4359d195c9f8f4a9415644ba3e334d316fe6b2
Author: Geoffrey Garen <[email protected]>
Date: 2026-04-27 (Mon, 27 Apr 2026)
Changed paths:
M Source/WTF/wtf/CheckedPtr.h
M Source/WTF/wtf/CheckedRef.h
M Source/WTF/wtf/TypeCasts.h
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXTextMarker.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/platform/graphics/Path.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderSearchField.cpp
M Source/WebCore/rendering/RenderTableCol.cpp
M Source/WebCore/rendering/svg/RenderSVGTextPath.cpp
M Source/WebCore/rendering/svg/RenderSVGTextPath.h
M Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp
Log Message:
-----------
Adopt LIFETIME_BOUND in the downcast family of functions
https://bugs.webkit.org/show_bug.cgi?id=313279
rdar://175553251
Reviewed by David Kilzer.
This was review feedback on a previous patch: We want lifetime information to
survive casting, so that we catch cases where we use the casted value past
its known / safe lifetime.
Adopted unsafeGet() for all the pre-existing cases, so we can start enforcing
this restriction from now on.
* Source/WTF/wtf/CheckedPtr.h:
(WTF::downcast):
* Source/WTF/wtf/CheckedRef.h:
(WTF::downcast):
* Source/WTF/wtf/TypeCasts.h:
(WTF::uncheckedDowncast):
(WTF::downcast):
(WTF::dynamicDowncast):
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::Accessibility::findUnignoredChild):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedObjectForNode):
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::Accessibility::findObjectWithRuns):
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::ownerParentObject const):
(WebCore::AccessibilityNodeObject::parentRow const):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::anchorElement const):
(WebCore::AccessibilityRenderObject::observableObject const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::containing):
* Source/WebCore/platform/graphics/Path.cpp:
(WebCore::Path::ensurePlatformPathImpl):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::offsetParent const):
* Source/WebCore/rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::recentSearches):
* Source/WebCore/rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::nextColumn const):
* Source/WebCore/rendering/svg/RenderSVGTextPath.cpp:
(WebCore::RenderSVGTextPath::targetElement const):
* Source/WebCore/rendering/svg/RenderSVGTextPath.h:
* Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp:
(WebKit::WebFoundTextRangeController::frameForFoundTextRange const):
Canonical link: https://commits.webkit.org/312106@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
