Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 07fca8af64294eb89b93aa73690725c4f7399821
https://github.com/WebKit/WebKit/commit/07fca8af64294eb89b93aa73690725c4f7399821
Author: Anthony Tarbinian <[email protected]>
Date: 2026-04-27 (Mon, 27 Apr 2026)
Changed paths:
M
LayoutTests/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny.html
M LayoutTests/platform/ios-site-isolation/TestExpectations
M LayoutTests/platform/mac-site-isolation/TestExpectations
M
LayoutTests/platform/wk2/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny-expected.txt
Log Message:
-----------
[Site Isolation]
http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny.html
is failing
https://bugs.webkit.org/show_bug.cgi?id=313169
rdar://175456456
Reviewed by Sihui Liu.
With site isolation enabled
http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny.html
fails with a test diff.
First, it is missing the following two log messages which come
from enabling testRunner.dumpResourceLoadCallbacks()
-http://localhost:8000/.../x-frame-options-deny-meta-tag-subframe-parent-same-origin-deny.html
- willSendRequest ...
-http://localhost:8000/.../x-frame-options-deny-meta-tag-subframe-parent-same-origin-deny.html
- didReceiveResponse ...
This was because testRunner.dumpResourceLoadCallbacks() is enabled via
the InjectedBundle which doesn't work since InjectedBundle
state doesn't get synced between processes with site isolation enabled.
Originally, I tried moving the testRunner state to the UIProcess which
allows the resource load logs to show up. It follows the convention
from https://commits.webkit.org/291512@main
Once the flag was working, the remaining issue was that the logs
printed out by dumpResourceLoadCallbacks would be printed out in different
ordering with site isolation enabled vs disabled. These logs include events
such as willSendRequest or didFinishLoading.
To have the site isolation behavior match pre site isolation behavior
we can remove the call to testRunner.dumpResourceLoadCallbacks so the
loading event logs don't get printed. This matches the convention
from https://commits.webkit.org/308790@main
This test already has other passing criteria besides the
loading event logs. It checks if the iframe's location.href is readable.
This patch fixes
http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny.html
with site isolation enabled.
*
LayoutTests/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny.html:
* LayoutTests/platform/ios-site-isolation/TestExpectations:
* LayoutTests/platform/mac-site-isolation/TestExpectations:
*
LayoutTests/platform/wk2/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny-expected.txt:
Canonical link: https://commits.webkit.org/312174@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
