Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6ff991b88b5ffb1194feb9e0b0db65dbc9756798
https://github.com/WebKit/WebKit/commit/6ff991b88b5ffb1194feb9e0b0db65dbc9756798
Author: Philippe Normand <[email protected]>
Date: 2026-04-28 (Tue, 28 Apr 2026)
Changed paths:
M LayoutTests/platform/gtk/TestExpectations
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerIceAgent.cpp
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerIceStream.cpp
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpSenderBackend.cpp
Log Message:
-----------
[GStreamer][Rice] Flaky crash in
`rice_proto::conncheck::ConnCheckList::add_local_candidate_internal()`
https://bugs.webkit.org/show_bug.cgi?id=312269
Reviewed by Xabier Rodriguez-Calvar.
There was a race condition where the agent would start closing, wake-up it main
loop and that would
trigger a local candidate notification after rice_agent_close() was called. We
now distinguish the
"closing" case from the "closed" case using an enum that can be checked before
processing local
candidate notifications.
* LayoutTests/platform/gtk/TestExpectations:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerIceAgent.cpp:
(_WebKitGstIceAgentPrivate::WTF_GUARDED_BY_LOCK):
(webkitGstWebRTCIceAgentAddStream):
(webkitGstWebRTCIceAgentClosed):
(webkitGstWebRTCIceAgentClose):
(webkitGstWebRTCIceAgentConstructed):
(webkitGstWebRTCIceAgentLocalCandidateGatheredForStream):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerIceStream.cpp:
(webkitGstWebRTCIceStreamAddLocalGatheredCandidate):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpSenderBackend.cpp:
(WebCore::GStreamerRtpSenderBackend::getParameters const):
Canonical link: https://commits.webkit.org/312189@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
