[webkit-changes] [114752] trunk/LayoutTests

Fri, 20 Apr 2012 09:15:55 -0700

Title: [114752] trunk/LayoutTests
Revision
114752
Author
[email protected]
Date
2012-04-20 09:15:48 -0700 (Fri, 20 Apr 2012)

Log Message

Layout Test svg/transforms/transform-origin-css-property.xhtml is failing
https://bugs.webkit.org/show_bug.cgi?id=84203

Reviewed by Simon Fraser.

This test compares CSS div's n a ref-test with a single spec for transform-origin
to SVG rects with multipe specs for transform-origin that are supposed
to all be equivalent, such as [50%,50%] and [center, center]. It fails
due to one-pixel differences on Chromium.

This change renders as many divs in the ref-test as SVG rects in the
test, and ends up with the same result. It seems likely that one of
the several specs that are used is computed slightly differently
(maybe 50% is not the same as center).

* platform/chromium/test_expectations.txt:
* svg/transforms/transform-origin-css-property-expected.xhtml:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (114751 => 114752)


--- trunk/LayoutTests/ChangeLog	2012-04-20 16:13:05 UTC (rev 114751)
+++ trunk/LayoutTests/ChangeLog	2012-04-20 16:15:48 UTC (rev 114752)
@@ -1,5 +1,25 @@
 2012-04-20  Stephen Chenney  <[email protected]>
 
+        Layout Test svg/transforms/transform-origin-css-property.xhtml is failing
+        https://bugs.webkit.org/show_bug.cgi?id=84203
+
+        Reviewed by Simon Fraser.
+
+        This test compares CSS div's n a ref-test with a single spec for transform-origin
+        to SVG rects with multipe specs for transform-origin that are supposed
+        to all be equivalent, such as [50%,50%] and [center, center]. It fails
+        due to one-pixel differences on Chromium.
+
+        This change renders as many divs in the ref-test as SVG rects in the
+        test, and ends up with the same result. It seems likely that one of
+        the several specs that are used is computed slightly differently
+        (maybe 50% is not the same as center).
+
+        * platform/chromium/test_expectations.txt:
+        * svg/transforms/transform-origin-css-property-expected.xhtml:
+
+2012-04-20  Stephen Chenney  <[email protected]>
+
         Remove empty svg/misc directory
         https://bugs.webkit.org/show_bug.cgi?id=79917

Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (114751 => 114752)


--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-04-20 16:13:05 UTC (rev 114751)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-04-20 16:15:48 UTC (rev 114752)
@@ -1282,9 +1282,6 @@
 
 BUGWK83875 LINUX : svg/text/font-size-below-point-five.svg = PASS TEXT
 
-// The ref test is failing? Very odd if so.
-BUGWK84203 : svg/transforms/transform-origin-css-property.xhtml = IMAGE
-
 // It is very hard to see why some of these are failing. The diff must be tiny in some cases.
 // Other fail intermittently in a way that is odd - clipping and masking should be stable.
 // It is probably a test design flaw.

Modified: trunk/LayoutTests/svg/transforms/transform-origin-css-property-expected.xhtml (114751 => 114752)


--- trunk/LayoutTests/svg/transforms/transform-origin-css-property-expected.xhtml	2012-04-20 16:13:05 UTC (rev 114751)
+++ trunk/LayoutTests/svg/transforms/transform-origin-css-property-expected.xhtml	2012-04-20 16:15:48 UTC (rev 114752)
@@ -22,22 +22,22 @@
        document.getElementById("divRoot").appendChild(div);
     }
 
-    var transformOrigins = [
-         "50% 50%",
-         "0% 0%",
-         "0% 50%",
-         "100% 0%",
-         "0% 50%",
-         "100% 50%",
-         "0% 100%",
-         "50% 100%",
-         "100% 100%",
+    var equivalentTransformOrigins = [
+         ["50% 50%", "center 50%", "50% center", "center", "center center"],
+         ["0% 0%", "left 0%", "0% top", "left top", "top left"],
+         ["0% 50%", "left 50%", "0% center", "left", "left center", "center left"],
+         ["100% 0%", "right 0%", "100% top", "right top", "top right"],
+         ["0% 50%", "left 50%", "0% center", "left center", "center left"],
+         ["100% 50%", "right 50%", "100% center", "right center", "center right"],
+         ["0% 100%", "left 100%", "0% bottom", "left bottom", "left bottom"],
+         ["50% 100%", "center 100%", "50% bottom", "bottom", "center bottom", "bottom center"],
+         ["100% 100%", "right 100%", "100% bottom", "right bottom", "bottom right"]
      ];
 
-     for (var i = 0; i < transformOrigins.length; i++)  {
+     for (var i = 0; i < equivalentTransformOrigins.length; i++)  {
          var x = 60 + (i %  4) * 60;
          var y = 60 + Math.floor(i / 4) * 60;
-         addTransformOriginDiv(x, y, transformOrigins[i]);
+         equivalentTransformOrigins[i].map( function(s) { addTransformOriginDiv(x, y, s); } );
      }
 
   ]]></script>

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to