Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7eee9e4580416d2768245eaffe92c1364b76142e
https://github.com/WebKit/WebKit/commit/7eee9e4580416d2768245eaffe92c1364b76142e
Author: Cole Carley <[email protected]>
Date: 2026-04-29 (Wed, 29 Apr 2026)
Changed paths:
M LayoutTests/platform/ios-site-isolation/TestExpectations
M LayoutTests/platform/mac-site-isolation/TestExpectations
M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
M Tools/WebKitTestRunner/TestInvocation.cpp
Log Message:
-----------
[Site Isolation] http/tests/misc/iframe-shadow-realm.html fails
https://bugs.webkit.org/show_bug.cgi?id=313592
rdar://175803484
Reviewed by Megan Gardner and Sihui Liu.
The test was failing due to a ReferenceError. The child frame
could not find the variable ShadowRealm.
The test passes the jscOption: --useShadowRealm=true. The bug
is that this option was not being propagated to the child frames
in site isolation.
The fix was to pass the the jscOptions from TestInvocation::invoke()
to InjectedBundle::beginTesting(), which will set the jscOptions
for the child pages.
This ensures that the child frame recieves the option useShadowRealm,
so it never hits the ReferenceError.
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::createTestSettingsDictionary):
Canonical link: https://commits.webkit.org/312325@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
