Diff
Modified: trunk/LayoutTests/ChangeLog (114765 => 114766)
--- trunk/LayoutTests/ChangeLog 2012-04-20 18:13:53 UTC (rev 114765)
+++ trunk/LayoutTests/ChangeLog 2012-04-20 18:41:15 UTC (rev 114766)
@@ -1,3 +1,21 @@
+2012-04-20 Dean Jackson <[email protected]>
+
+ -webkit-filter missing from computed style enumeration
+ https://bugs.webkit.org/show_bug.cgi?id=84468
+
+ Reviewed by Timothy Hatcher.
+
+ Added new results for platforms that have filters enabled. Hopefully
+ I got them all. Luckily there were already platform results for this
+ test in each case.
+
+ * platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
+ * platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
+ * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
+ * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
+ * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
+ * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
+
2012-04-20 Victor Carbune <[email protected]>
Ensure text is centered for default captions
Modified: trunk/LayoutTests/platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt (114765 => 114766)
--- trunk/LayoutTests/platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt 2012-04-20 18:13:53 UTC (rev 114765)
+++ trunk/LayoutTests/platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt 2012-04-20 18:41:15 UTC (rev 114766)
@@ -142,6 +142,7 @@
-webkit-column-rule-width: 0px;
-webkit-column-span: 1;
-webkit-column-width: auto;
+-webkit-filter: none;
-webkit-flex: 0 0 auto;
-webkit-flex-order: 0;
-webkit-flex-pack: start;
Modified: trunk/LayoutTests/platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (114765 => 114766)
--- trunk/LayoutTests/platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2012-04-20 18:13:53 UTC (rev 114765)
+++ trunk/LayoutTests/platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2012-04-20 18:41:15 UTC (rev 114766)
@@ -141,6 +141,7 @@
-webkit-column-rule-width: 0px
-webkit-column-span: 1
-webkit-column-width: auto
+ -webkit-filter: none
-webkit-flex: 0 0 auto
-webkit-flex-order: 0
-webkit-flex-pack: start
Modified: trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt (114765 => 114766)
--- trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt 2012-04-20 18:13:53 UTC (rev 114765)
+++ trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt 2012-04-20 18:41:15 UTC (rev 114766)
@@ -142,6 +142,7 @@
-webkit-column-rule-width: 0px;
-webkit-column-span: 1;
-webkit-column-width: auto;
+-webkit-filter: none;
-webkit-flex: 0 0 auto;
-webkit-flex-order: 0;
-webkit-flex-pack: start;
Modified: trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (114765 => 114766)
--- trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2012-04-20 18:13:53 UTC (rev 114765)
+++ trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2012-04-20 18:41:15 UTC (rev 114766)
@@ -141,6 +141,7 @@
-webkit-column-rule-width: 0px
-webkit-column-span: 1
-webkit-column-width: auto
+ -webkit-filter: none
-webkit-flex: 0 0 auto
-webkit-flex-order: 0
-webkit-flex-pack: start
Modified: trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-expected.txt (114765 => 114766)
--- trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-expected.txt 2012-04-20 18:13:53 UTC (rev 114765)
+++ trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-expected.txt 2012-04-20 18:41:15 UTC (rev 114766)
@@ -142,6 +142,7 @@
-webkit-column-rule-width: 0px;
-webkit-column-span: 1;
-webkit-column-width: auto;
+-webkit-filter: none;
-webkit-flex: 0 0 auto;
-webkit-flex-order: 0;
-webkit-flex-pack: start;
Modified: trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (114765 => 114766)
--- trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2012-04-20 18:13:53 UTC (rev 114765)
+++ trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2012-04-20 18:41:15 UTC (rev 114766)
@@ -141,6 +141,7 @@
-webkit-column-rule-width: 0px
-webkit-column-span: 1
-webkit-column-width: auto
+ -webkit-filter: none
-webkit-flex: 0 0 auto
-webkit-flex-order: 0
-webkit-flex-pack: start
Modified: trunk/Source/WebCore/ChangeLog (114765 => 114766)
--- trunk/Source/WebCore/ChangeLog 2012-04-20 18:13:53 UTC (rev 114765)
+++ trunk/Source/WebCore/ChangeLog 2012-04-20 18:41:15 UTC (rev 114766)
@@ -1,3 +1,19 @@
+2012-04-20 Dean Jackson <[email protected]>
+
+ -webkit-filter missing from computed style enumeration
+ https://bugs.webkit.org/show_bug.cgi?id=84468
+
+ Reviewed by Timothy Hatcher.
+
+ CSSComputedStyleDeclaration has a list of properties that it exposes.
+ While the computed style for filter was available, the property wasn't
+ listed and hence missing in clients like the Web Inspector.
+
+ Covered by existing tests.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore): add CSSPropertyWebkitFilter
+
2012-04-20 Emil A Eklund <[email protected]>
[win] Update windows platform code to use pixel snapped values
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (114765 => 114766)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2012-04-20 18:13:53 UTC (rev 114765)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2012-04-20 18:41:15 UTC (rev 114766)
@@ -220,6 +220,9 @@
#if ENABLE(DASHBOARD_SUPPORT)
CSSPropertyWebkitDashboardRegion,
#endif
+#if ENABLE(CSS_FILTERS)
+ CSSPropertyWebkitFilter,
+#endif
CSSPropertyWebkitFlex,
CSSPropertyWebkitFlexOrder,
CSSPropertyWebkitFlexPack,
