Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d4aae9fc6b343d0c4c66fd30544d288067d250e0
https://github.com/WebKit/WebKit/commit/d4aae9fc6b343d0c4c66fd30544d288067d250e0
Author: Kimmo Kinnunen <[email protected]>
Date: 2026-05-04 (Mon, 04 May 2026)
Changed paths:
M Source/ThirdParty/ANGLE/src/libANGLE/Caps.h
M Source/ThirdParty/ANGLE/src/libANGLE/ErrorStrings.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm
M Source/ThirdParty/ANGLE/src/libANGLE/validationES.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/validationES.h
M Source/ThirdParty/ANGLE/src/tests/gl_tests/BaseInstanceOverflowTest.cpp
M Source/ThirdParty/ANGLE/src/tests/test_utils/ANGLETest.h
Log Message:
-----------
ANGLE: Metal: BaseInstanceOverflowTest.BaseInstanceOverflow fails validation
https://bugs.webkit.org/show_bug.cgi?id=313730
rdar://175929622
Reviewed by Dan Glastonbury.
Metal backend uses the instanced draw commands of Metal directly, passing
baseInstance and count without any emulation.
The language semantics differ:
MSL: uint instance_id = baseInstance + instance
GLSL: GLuint gl_Instance = instance
Fix the BaseInstanceOverflowTest.BaseInstanceOverflow to not fail
by adding a backend-specific limitation to disallowing such big
baseInstanstance + primcount calls.
* Source/ThirdParty/ANGLE/src/libANGLE/Caps.h:
* Source/ThirdParty/ANGLE/src/libANGLE/ErrorStrings.h:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm:
(rx::DisplayMtl::ensureCapsInitialized const):
* Source/ThirdParty/ANGLE/src/libANGLE/validationES.cpp:
(gl::ValidateDrawElementsInstancedBase):
(gl::ValidateDrawArraysInstancedBase):
* Source/ThirdParty/ANGLE/src/libANGLE/validationES.h:
(gl::ValidateDrawInstancedCounts):
* Source/ThirdParty/ANGLE/src/tests/gl_tests/BaseInstanceOverflowTest.cpp:
(TEST_P):
* Source/ThirdParty/ANGLE/src/tests/test_utils/ANGLETest.h:
(ANGLETestBase::isMetalRenderer const):
Canonical link: https://commits.webkit.org/312507@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
