Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 84ee097bb243144d9b10814ee3dd3f9eaeff5992
https://github.com/WebKit/WebKit/commit/84ee097bb243144d9b10814ee3dd3f9eaeff5992
Author: Etienne Segonzac <[email protected]>
Date: 2026-05-04 (Mon, 04 May 2026)
Changed paths:
M Source/WebKit/WebProcess/GPU/graphics/Model/RemoteMeshProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/Model/RemoteMeshProxy.h
Log Message:
-----------
Setting the entityTransform on <model> should override the auto fit behavior
https://bugs.webkit.org/show_bug.cgi?id=313747
<rdar://175774632>
Reviewed by Mike Wyrzykowski.
When stage mode is None, setting an `entityTransform` on a model should
override the computed auto fit transform.
But we should still attempt to auto fit on load and until the transform
is set by script.
* Source/WebKit/WebProcess/GPU/graphics/Model/RemoteMeshProxy.cpp:
(WebKit::RemoteMeshProxy::setEntityTransform):
Directly set the entityTransform without computing the auto fit
transform.
Also updated the m_computedTransform since this is what we report back
to script.
(WebKit::RemoteMeshProxy::setStageMode):
Reset the "set by script" flag when the stage mode is updated to orbit.
(WebKit::RemoteMeshProxy::computeTransform):
Skip computation when the entity transform has been set by script.
* Source/WebKit/WebProcess/GPU/graphics/Model/RemoteMeshProxy.h:
Add a flag to keep track of when the entityTransform is set by script.
Canonical link: https://commits.webkit.org/312520@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications