Title: [114783] trunk/Source/WebCore
- Revision
- 114783
- Author
- [email protected]
- Date
- 2012-04-20 14:37:03 -0700 (Fri, 20 Apr 2012)
Log Message
Crash in getOrDrawNodeHighlight after r114659
https://bugs.webkit.org/show_bug.cgi?id=84486
Patch by Xianzhu Wang <[email protected]> on 2012-04-20
Reviewed by Daniel Bates.
No new tests. Fixes a crash in test: inspector/elements/elements-panel-selection-on-refresh.html.
* inspector/DOMNodeHighlighter.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (114782 => 114783)
--- trunk/Source/WebCore/ChangeLog 2012-04-20 21:29:00 UTC (rev 114782)
+++ trunk/Source/WebCore/ChangeLog 2012-04-20 21:37:03 UTC (rev 114783)
@@ -1,3 +1,14 @@
+2012-04-20 Xianzhu Wang <[email protected]>
+
+ Crash in getOrDrawNodeHighlight after r114659
+ https://bugs.webkit.org/show_bug.cgi?id=84486
+
+ Reviewed by Daniel Bates.
+
+ No new tests. Fixes a crash in test: inspector/elements/elements-panel-selection-on-refresh.html.
+
+ * inspector/DOMNodeHighlighter.cpp:
+
2012-04-20 Brady Eidson <[email protected]>
https://bugs.webkit.org/show_bug.cgi?id=84490
Modified: trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp (114782 => 114783)
--- trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp 2012-04-20 21:29:00 UTC (rev 114782)
+++ trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp 2012-04-20 21:37:03 UTC (rev 114783)
@@ -366,11 +366,11 @@
Node* node = highlightData->node.get();
RenderObject* renderer = node->renderer();
Frame* containingFrame = node->document()->frame();
- FrameView* containingView = containingFrame->view();
if (!renderer || !containingFrame)
return;
+ FrameView* containingView = containingFrame->view();
LayoutRect boundingBox = containingView->contentsToRootView(renderer->absoluteBoundingBoxRect());
LayoutRect titleAnchorBox = boundingBox;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
