Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cc45b685202c5c4fcc8d94a8e19990799f6e20a8
https://github.com/WebKit/WebKit/commit/cc45b685202c5c4fcc8d94a8e19990799f6e20a8
Author: Tadeu Zagallo <[email protected]>
Date: 2026-05-05 (Tue, 05 May 2026)
Changed paths:
M
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/clamp-expected.txt
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/TypeCheck.cpp
Log Message:
-----------
[WGSL] shader,validation,expression,call,builtin,clamp:* is failing
https://bugs.webkit.org/show_bug.cgi?id=314112
rdar://176284824
Reviewed by Mike Wyrzykowski.
The validation for expressions containing override expressions shouldn't happen
in the type checker, as that runs for every function, even non-reachable ones
for the shader being compiled. Move that to the GlobalVariableRewriter instead
so only used expressions are checked.
*
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/clamp-expected.txt:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::getPacking):
* Source/WebGPU/WGSL/TypeCheck.cpp:
Canonical link: https://commits.webkit.org/312670@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
